test(composer): reuse fixtures and restore required lint checks

[nwparker]

	Files	Added	Deleted	Net
Test	2	$\color{#1a7f37}{\Huge{\mathbf{+}}}$​2	$\color{#cf222e}{\Huge{\mathbf{−}}}$​71	$\color{#cf222e}{\Huge{\mathbf{−}}}$​69
Prod	2	$\color{#1a7f37}{\Huge{\mathbf{+}}}$​37	$\color{#cf222e}{\Huge{\mathbf{−}}}$​2	$\color{#1a7f37}{\Huge{\mathbf{+}}}$​35

ELI5

Fix two lint errors already on main so the reviewed PRs can pass required checks.

What Changed

Move the existing folder-composer test factories into one test fixture module and reuse them in both suites. Preserve every assertion, default, override, and the newly merged manual-name cases. Remove an unused settings dependency from the automation hook callback; its existing cache-key callback still depends on settings and preserves invalidation.

Why

Pristine main fails with an 808-line test file against the 800-line limit and a redundant hook dependency. Reusing identical factories fixes the size limit without disabling it or dropping tests. Removing a dependency the callback does not read fixes the warning without changing its inputs.

Linked Issue

Prerequisite for #27142, #24674, #24964, and #27321. No additional issue needed for this maintainer CI repair.

Visual Proof

N/A — shared test data and a redundant dependency cleanup; rendered behavior is unchanged.

Testing

• Reproduced both lint failures on pristine main under the same command.
• The edited files lint clean; 37 existing tests across three suites pass.

Typecheck and changed-code quality pass. A byte comparison confirms the original primary-suite factory bodies and all its test bodies are unchanged. An independent second audit confirms the host suite’s no-argument calls retain identical data and hook invalidation is preserved through the retained cache-key dependency. Full pnpm lint passes locally. Hosted CI will cover broader checks.

Review

Low merge risk. No new feature, API, IPC, credential access, host routing, or visual change. The original contributor tests and their history are retained.

Agent skill upstream boundary

• Not applicable; no upstream skill-installer material copied.

Checklist

• Small prerequisite cleanup.
• Problem, resulting behavior, mechanism, and approach explained.
• Visual proof marked N/A with reason.
• Mechanical preservation and hook dependency independently reviewed.
• Cross-platform, SSH, folder, and wire behavior unchanged.
• Focused tests, typecheck, and quality pass; CI covers broader verification.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 7271c3a9-8fc5-4f2f-98e1-6f535b17ce2d

---

📥 Commits

Reviewing files that changed from the base of the PR and between 68519e6 and 3bc0200.

---

📒 Files selected for processing (4)

• src/renderer/src/components/automations/use-automations-page-setup-state.ts
• src/renderer/src/components/sidebar/folder-workspace-composer-submit-fixtures.ts
• src/renderer/src/components/sidebar/folder-workspace-composer-submit-host-platform.test.ts
• src/renderer/src/components/sidebar/folder-workspace-composer-submit.test.ts

---

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review.

---

---

📝 Walkthrough

Walkthrough

The automation hook-loading callback no longer depends on settings. Folder workspace submission tests now import shared project group and folder workspace fixture factories instead of defining those helpers locally.

---

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 3bc02

The changes preserve the existing test scenarios and settings-sensitive cache-key behavior; no actionable merge risk remains.

Pre-merge checks | 4 | 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 4 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check		The title clearly identifies the main changes: shared composer fixture reuse and restoration of required lint checks.
Description check		The description covers the required sections, explains the changes and rationale, documents testing, provides the visual-proof exception, and addresses review and compatibility considerations.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

---

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 2

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

---

🛠️ Fix failing CI checks 💡

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

---

_{Comment @coderabbitai help to get the list of available commands.}

[nwparker]

The identical cleanup is now on main through the author-preserving rebase merges of #24674 and #27321. Verified all four cleanup files match main exactly. Closing this duplicate as covered; the original cleanup authorship and independent audit are retained.