Repository navigation
Await ACP session opening under host ownership - #28047
Closed
brennanb2025 wants to merge 102 commits into
Closed
brennanb2025 wants to merge 102 commits into
brennanb2025 wants to merge 102 commits into
Conversation
5 of 7 tasks
brennanb2025
force-pushed
the
brennanb2025/agent-start-split-3-acp-start
branch
from
October 12, 2026 19:39
e5c1de3 to
8454fe1
Compare
This was referenced Oct 12, 2026
brennanb2025
force-pushed
the
brennanb2025/agent-start-split-2-codex-start
branch
from
October 12, 2026 21:31
7be6240 to
1232065
Compare
brennanb2025
force-pushed
the
brennanb2025/agent-start-split-3-acp-start
branch
from
October 12, 2026 21:31
8454fe1 to
699a59a
Compare
# Conflicts: # src/main/native-chat/agent-session-wire/structured-agent-session-attach-flow.ts # src/main/native-chat/agent-session-wire/structured-agent-session-attach-orchestration.ts # src/main/native-chat/agent-session-wire/structured-agent-session-host-mutations.ts # src/main/native-chat/agent-session-wire/structured-agent-session-host-types.ts # src/main/runtime/structured-agent-session-runtime.ts # src/renderer/src/components/native-chat/use-structured-agent-session-option-state.ts
# Conflicts: # src/main/acp/acp-structured-host-option-hang.test.ts
brennanb2025
changed the base branch from
brennanb2025/agent-start-split-2-codex-start
to
main
October 17, 2026 00:51
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
A chat using Grok or another Agent Client Protocol (ACP) agent could stay busy while initialization, sign-in or session restoration held the request that started it. Stop, close and failure then relied on a separate adapter path.
What Changed
The host now publishes the ACP process and awaits its open before sending input. Initialization, authentication, session restore with a fresh-session fallback, and configuration keep their existing order. Sign-in refusal shows the agent's words; other errors keep their diagnostic. Ready fields are installed only after the final live check. A catalog-save failure is logged through the existing helper and cannot fail the options read. The new running-work and process-liveness checks keep an active ACP turn from being evicted as idle and supply first-hand process evidence.
Why
One host-owned opening replaces the separate adapter startup path. Stop remains a session boundary because ACP protocol replies cannot reliably separate late work from a stopped turn; the next send opens a fresh session. Startup errors use the existing sign-in mapping and retain other diagnostics.
Differences from the common pattern
Linked Issue
Replaces the ACP-startup portion of #26561; depends on #28046 and #27925.
Visual Proof
Rendered before/after evidence is pending. Scripted tests cover the behavior; no screenshot or manual platform evidence is claimed.
Testing
Focused ACP opening, authentication, close and late-reply tests; Node and CI project typechecks; static checks with the accepted pinned-main HtmlDocPreview exception. Scripted macOS tests only; no rendered or remote-host QA.
Review
Reviewed the owning diff, failure paths and covered races. Tests demonstrate covered behaviors; rendered and real remote-host QA are pending.
Agent skill upstream boundary
Notes
Execution stays on the host owning the agent. Folder workspaces and independently updated peers retain their existing paths. Loss of contact is not process-exit evidence. Draft only; no main sync or hosted CI watch.
Checklist