Fail signed-out Pi opening before delivering input

config/scripts/vitest-sqlite-runtime-files.mjs

@@ -2,6 +2,8 @@ import { SQLITE_DATABASE_RUNTIME_INCLUDE } from './vitest-sqlite-database-runtim
 
 // Real SQLite fixtures keep Node publication and close semantics.
 export const SQLITE_RUNTIME_INCLUDE = [
+  'src/main/pi/rpc-session-adapter.test.ts',
+  'src/main/pi/rpc-session-startup.test.ts',
   'src/main/acp/acp-structured-publish-at-spawn.test.ts',
   'tests/e2e/native-chat-startup-option-pickers.unit.test.ts',
   ...SQLITE_DATABASE_RUNTIME_INCLUDE,
@@ -255,6 +257,10 @@ export const SQLITE_RUNTIME_INCLUDE = [
   'src/main/runtime/runtime-client-agent-launch-settings-durability.test.ts',
   'src/main/runtime/structured-agent-session-codex-scripted-child.test.ts',
   'src/main/runtime/structured-agent-session-codex-start-deadline.test.ts',
+  'src/main/runtime/structured-agent-session-pi-startup.test.ts',
+  'src/main/runtime/structured-agent-session-pi-signed-out-start.test.ts',
+  'src/main/runtime/structured-agent-session-adapter-start-failure.test.ts',
+  'src/main/runtime/structured-agent-session-provider-operations-while-starting.test.ts',
   'src/main/runtime/structured-agent-session-codex-settlement-order.test.ts',
   'src/main/runtime/structured-agent-session-integration-replay.test.ts',
   'src/main/runtime/structured-agent-session-integration.test.ts',

src/main/jsonl-rpc/agent-connection.ts

@@ -1,5 +1,6 @@
 import type { PipedProcessSpawner } from '@orca/process-host/process-spec'
 import { spawnProcess } from '@orca/process-host'
+import { providerDiagnostic, withProviderDiagnostic } from '../../shared/agent-session-failure'
 import {
   spawnManagedProviderProcess,
   type ManagedProviderProcess,
@@ -81,10 +82,14 @@ export class JsonlRpcAgentConnection {
     managed.child.stderr.on('error', this.onError)
     managed.onExit((exit) => {
       clearTimeout(this.streamExitTimer)
-      const error = new Error(
-        exit.processless
-          ? 'Agent process could not start'
-          : `Agent process exited (code ${exit.code ?? 'none'}, signal ${exit.signal ?? 'none'})`
+      // The agent's last stderr lines are what a person can act on when it dies.
+      const error = withProviderDiagnostic(
+        new Error(
+          exit.processless
+            ? 'Agent process could not start'
+            : `Agent process exited (code ${exit.code ?? 'none'}, signal ${exit.signal ?? 'none'})`
+        ),
+        providerDiagnostic(managed.stderrTail(), 'person')
       )
       this.peer.finishOnInputEnd(error)
       const stdout = managed.child.stdout

src/main/native-chat/agent-session-wire/structured-agent-session-adapter-router.ts

@@ -136,9 +136,6 @@ export class StructuredAgentSessionAdapterRouter implements StructuredAgentSessi
     this.liveOwnerOrNull(sessionId)?.holdsLiveProviderProcess?.(sessionId, acquisitionGeneration) ??
     false
 
-  startUnavailable: NonNullable<StructuredAgentSessionAdapter['startUnavailable']> = (sessionId) =>
-    this.liveOwnerOrNull(sessionId)?.startUnavailable?.(sessionId)
-
   stopEndsSession = (sessionId: string): boolean =>
     this.liveOwnerOrNull(sessionId)?.stopEndsSession?.(sessionId) ?? false
 

src/main/native-chat/agent-session-wire/structured-agent-session-adapter.ts

@@ -1,7 +1,4 @@
-import type {
-  AgentSessionAccountKind,
-  AgentSessionUnavailable
-} from '../../../shared/agent-session-availability'
+import type { AgentSessionAccountKind } from '../../../shared/agent-session-availability'
 import type {
   AgentSessionRewindReason,
   AgentSessionRewindSupport
@@ -368,9 +365,6 @@ export type StructuredAgentSessionAdapter = StructuredAgentSessionAdapterStop &
   /** The adapter's own child for this exact acquisition has a pid and its root exit has not been
    *  seen: first-hand proof of life for lease renewal. Absent or false falls back to a PID probe. */
   holdsLiveProviderProcess?(sessionId: string, acquisitionGeneration: string): boolean
-  /** Why the session's running child can take no turn, as its own start found; undefined when
-   *  unknown or no child runs. Lives and dies with that child. */
-  startUnavailable?(sessionId: string): AgentSessionUnavailable | undefined
   /** The `/` surface the running provider reports for itself. Undefined when the
    *  provider never reports one, which is what keeps the client on its catalog. */
   readCommands?(sessionId: string): AgentSessionSlashCommand[] | undefined

src/main/native-chat/agent-session-wire/structured-agent-session-host-delivery.ts

@@ -94,7 +94,6 @@ export function createStructuredAgentSessionConversationDelivery(input: {
           },
           providerHoldsDispatch: () => deps.adapter.holdsDispatch?.(sessionId) === true
         },
-        startUnavailable: () => deps.adapter.startUnavailable?.(sessionId),
         launchPermission: async () => {
           const record = deps.store.getRecord(sessionId)
           return record ? structuredAgentSessionLaunchPermission(deps, record) : null
@@ -205,7 +204,7 @@ export function createStructuredAgentSessionConversationDelivery(input: {
  * A rewind found prepared when the conversation opens was started under a child this process no
  * longer has — the open runs only when none is indexed — so nothing will finish it, and left alone
  * it refuses every send until a view attaches. Settled here instead of by a start inside
- * acceptance. A Codex rewind only its provider can prove stays for the attach.
+ * acceptance. A Codex rewind only its provider can prove stays for the next proven start.
  */
 async function settleInterruptedCommands(
   deps: StructuredAgentSessionHostDeps,

src/main/native-chat/agent-session-wire/structured-agent-session-outgrown-child.test.ts

@@ -28,7 +28,6 @@ import type {
   AgentJournalTurnLifecycle
 } from '../../../shared/agent-session-journal-types'
 import type { AgentChildWorkView } from '../../../shared/agent-status-child-work-view'
-import type { AgentSessionUnavailable } from '../../../shared/agent-session-availability'
 import type { JournalItemLinkageVisitor } from '../agent-session-journal/journal-store-contracts'
 import type { StructuredAgentSessionChildWorkReads } from './structured-agent-session-idle-sweep'
 
@@ -69,17 +68,6 @@ describe('a send after the agent said it is not signed in', () => {
     expect(rig.adapter.acquire).toHaveBeenCalledTimes(2)
   })
 
-  // A Pi that started with no model keeps a placeholder: a sign-in made since reaches a new Pi only.
-  it('goes to a new agent when the running one started signed out', async () => {
-    await foundRestTestChat(rig)
-    rig.adapter.startUnavailable.mockReturnValueOnce({ reason: 'notSignedIn' })
-    rig.adapter.closeSession.mockClear()
-    expect((await rig.host.send(CALLER, restTestSend('signed in since', fence()))).ok).toBe(true)
-    await vi.waitFor(() => expect(rig.adapter.dispatch).toHaveBeenCalledTimes(2))
-    expect(rig.adapter.closeSession).toHaveBeenCalledWith(SESSION)
-    expect(rig.adapter.acquire).toHaveBeenCalledTimes(2)
-  })
-
   it('keeps the agent after any other rejection', async () => {
     await foundRestTestChat(rig)
     rig.adapter.dispatch.mockImplementationOnce(async () => ({
@@ -180,14 +168,6 @@ describe('structuredAgentSessionChildReportedSignedOut', () => {
     expect(reported({ items, child: childAt({ phase: 'starting' }) })).toBe(false)
     expect(reported({ items, child: null })).toBe(false)
   })
-
-  it("reads the running child's own start, and only a signed-out one", () => {
-    const fromStart = (startUnavailable: AgentSessionUnavailable, child = childAt({})) =>
-      structuredAgentSessionChildReportedSignedOut(conversation({ child }), startUnavailable)
-    expect(fromStart({ reason: 'notSignedIn' })).toBe(true)
-    expect(fromStart({ reason: 'cliMissing' })).toBe(false)
-    expect(fromStart({ reason: 'notSignedIn' }, childAt({ phase: 'starting' }))).toBe(false)
-  })
 })
 
 describe('retireOutgrownStructuredAgentSessionChild', () => {

src/main/native-chat/agent-session-wire/structured-agent-session-outgrown-child.ts

@@ -1,7 +1,6 @@
 // A child the chat outgrew (signed out, or launched with another permission mode) is replaced before
 // the next send: agents read their login and permission mode only when they start.
 
-import type { AgentSessionUnavailable } from '../../../shared/agent-session-availability'
 import { readWholeAgentSessionFailureFact } from '../../../shared/agent-session-failure'
 import { isRootAgentJournalItem } from '../../../shared/agent-session-journal-producer'
 import type { AgentJournalSubmission } from '../../../shared/agent-session-journal-types'
@@ -28,20 +27,15 @@ type OutgrownChildReading = Pick<StructuredAgentSessionHostSession, 'child'> & {
 const signedOut = (failure: unknown): boolean =>
   readWholeAgentSessionFailureFact(failure)?.kind === 'notSignedIn'
 
-/** The running child itself said it is not signed in: its start, a send it rejected, or a row it
- *  wrote. Each child holds its own fence, so matching it scopes both to this child; a new one has
- *  nothing. `startUnavailable` is the adapter's read of that child's start. */
+/** The running child itself said it is not signed in through a rejected send or a row it wrote.
+ *  Its fence scopes both to this child, so a new one has nothing. */
 export function structuredAgentSessionChildReportedSignedOut(
-  session: OutgrownChildReading,
-  startUnavailable?: AgentSessionUnavailable
+  session: OutgrownChildReading
 ): boolean {
   const { child, journal } = session
   if (!child || child.phase === 'starting' || child.close) {
     return false
   }
-  if (startUnavailable?.reason === 'notSignedIn') {
-    return true
-  }
   if (
     journal
       .submissions()
@@ -99,7 +93,6 @@ export async function retireOutgrownStructuredAgentSessionChild(
   session: OutgrownChildReading | undefined,
   deps: {
     work: StructuredAgentSessionChildWorkReads
-    startUnavailable?: () => AgentSessionUnavailable | undefined
     /** The mode a start of the chat would launch with now. */
     launchPermission?: () => Promise<AgentChatPermissionMode | null>
     stopAgent: (sessionId: string) => Promise<void>
@@ -109,7 +102,7 @@ export async function retireOutgrownStructuredAgentSessionChild(
   if (
     !session ||
     !(
-      structuredAgentSessionChildReportedSignedOut(session, deps.startUnavailable?.()) ||
+      structuredAgentSessionChildReportedSignedOut(session) ||
       (await launchedWithOtherPermissionMode(session.child, deps.launchPermission))
     ) ||
     structuredAgentSessionChildHasOpenWork(session.journal, deps.work) ||

src/main/native-chat/agent-session-wire/structured-agent-session-rest-test-rig.ts

@@ -50,7 +50,6 @@ export type RestTestAdapter = {
     NonNullable<StructuredAgentSessionAdapter['acknowledgeSessionRelease']>
   >
   holdsDispatch: Mock<NonNullable<StructuredAgentSessionAdapter['holdsDispatch']>>
-  startUnavailable: Mock<NonNullable<StructuredAgentSessionAdapter['startUnavailable']>>
   readOptions: Mock<NonNullable<StructuredAgentSessionAdapter['readOptions']>>
 }
 
@@ -166,7 +165,6 @@ export async function createRestTestRig(
     dispatch: vi.fn(async () => acceptedDispatch()),
     acknowledgeSessionRelease: vi.fn(),
     holdsDispatch: vi.fn(() => false),
-    startUnavailable: vi.fn(() => undefined),
     readOptions: vi.fn(async () => ({ models: [], current: { model: 'gpt-live' } }))
   }
   const starts = structuredAgentSessionHeldStarts(() => rig.host)