Repository navigation
refactor(chat): give the start-refusal resumable table its own module - #28085
Merged
Merged
Conversation
8 tasks done
brennanb2025
added a commit
that referenced
this pull request
Oct 12, 2026
…27875) * fix(browser): annotation card and outline follow the selected element The grab overlay keeps re-measuring the picked element after the click (scroll in any box, resize, element size changes), and the isolated viewport bridge reports that live box so the pending card follows it, including page zoom. The card's side pick uses its measured height. * fix(browser): bind annotation card to selected element * fix(browser): keep document annotation card on selection * fix(ci): point the main sync-spawn ratchet at the shared ratchet library (#28054) #27756's script imported baseline helpers from check-focus-read-ratchet.mjs after #27788 had moved them into ratchet-baseline.mjs, so it crashed on start and failed every PR that merges main. Use the library's helpers, and record the two daemon-process launches from #27769 that the broken check never saw. Co-authored-by: Orca Worker <orca-worker@localhost> * fix(browser): follow selected element outer-box size * refactor(chat): give the start-refusal resumable table its own module (#28085) #27946 and #26684 together put agent-session-failure-words.ts at 304 lines, over max-lines, which fails lint and the pre-commit hook on every merge of main. The refusal-code table is standalone with one reader, so it moves out. Co-authored-by: Orca Worker <orca-worker@localhost> --------- Co-authored-by: OrcaWin <alpha-eng@stably.ai> Co-authored-by: Orca Worker <orca-worker@localhost>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
Two PRs merged a minute apart (#27946 and #26684) each added lines to
src/shared/agent-session-failure-words.ts. Each was under the 300-line lint limit alone; together they put it at 304. Every PR that merges main now fails lint, and the pre-commit hook rejects the merge commit. This moves one self-contained table into its own file.What Changed
START_REFUSAL_RESUMABLE, which records whether a refused start can be resumed for each wire refusal code, moves unchanged tosrc/shared/agent-session-start-refusal-resumable.ts.agent-session-failure-words.tsimports it from there and drops its now-unusedAgentSessionWireRefusalCodeimport. Nothing else referenced the table.Why
The table is a standalone classification with its own doc comment and one reader, so it splits cleanly. Moving it avoids a
max-linesdisable, which AGENTS.md forbids, and leaves the sentence-building code as it is.Linked Issue
Fixes the
mainlint break from #27946 + #26684 (agent-session-failure-words.tsat 304 lines, max-lines 300).Visual Proof
N/A: no behaviour change; a constant moves to its own module.
Testing
oxlint
--deny-warnings, the anti-slop config and oxfmt--checkpass on both files.tsc -p config/tsconfig.node.jsonreports nothing in either file. This checkout couldn't build@orca/process-host, so other files show unrelated module-resolution errors, and CI covers the full typecheck.I manually tested these changes locally
Automated tests added/updated (behaviour unchanged; existing failure-words tests cover the table's reader)
Checklist
N/Awith reason