Skip to content

fix(native-chat): drop the duplicate clock on the chat option write - #28591

Closed
brennanb2025 wants to merge 1 commit into
mainfrom
brennanb2025/fix-duplicate-now-key
Closed

brennanb2025 wants to merge 1 commit into
mainfrom
brennanb2025/fix-duplicate-now-key

Conversation

@brennanb2025

@brennanb2025 brennanb2025 commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 0 0 0 0
Prod 1 0 $\color{#cf222e}{\Huge{\mathbf{−}}}$​1 $\color{#cf222e}{\Huge{\mathbf{−}}}$​1

Problem

main doesn't typecheck, so every PR based on it fails "static analysis and typecheck" and skips its tests.

Two separate fixes for the same missing now clock both merged: #28571 and the same fix bundled into #28577. They touched different lines, so git combined them without a conflict. writeStructuredAgentSessionOption now builds an object literal with now twice, which TypeScript rejects.

Change

Delete the second entry, now: () => context.now(), and keep now: context.now from #28571. The nearby context builders (structured-agent-session-create.ts, structured-agent-session-host-mutations.ts) pass the clock the same way.

User-facing change

None. This only makes main typecheck again.

Two fixes for the same missing clock (#28571 and #28577) both landed and git merged
them side by side, so the object literal names `now` twice and main no longer
typechecks.
@coderabbitai

coderabbitai Bot commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2bd0f153-e369-4252-a173-16d99ca92825
📥 Commits

Reviewing files that changed from the base of the PR and between 5e1c117 and b695572.

📒 Files selected for processing: 1
  • src/main/native-chat/agent-session-wire/structured-agent-session-message-options.ts
💤 Files with no reviewable changes: 1
  • src/main/native-chat/agent-session-wire/structured-agent-session-message-options.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 2 remain after this review.

📝 Walkthrough

The local context object no longer includes the redundant now: () => context.now() property. The existing now: context.now property remains.

Priority: ➖ Normal

Merge Risk: ⚪ Minimal · up to b6955

The duplicate clock property is removed without changing how session options are written. No actionable merge risk remains.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning The description clearly explains the problem, the code change, and the lack of user-facing impact. However, it omits several template sections, including the linked issue, visual proof or an explicit … Complete the required template sections. Add the linked issue, state N/A with a reason for visual proof, document testing and platform coverage, complete the applicable AI disclosure and checklist items, and address review, compatibility, a…
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: removing the duplicate clock from the native-chat option write.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description clearly explains the problem, the code change, and the lack of user-facing impact. However, it omits several template sections, including the linked issue, visual proof or an explicit N/A statement, testing details, AI disclosure, review, boundary confirmation, notes, and checklist status.

Resolution

Complete the required template sections. Add the linked issue, state N/A with a reason for visual proof, document testing and platform coverage, complete the applicable AI disclosure and checklist items, and address review, compatibility, and boundary sections.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@brennanb2025

Copy link
Copy Markdown
Contributor Author

Closing: redundant. #28543 already removed the duplicate now entry on main.

@brennanb2025
brennanb2025 deleted the brennanb2025/fix-duplicate-now-key branch October 14, 2026 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant