Repository navigation
fix(native-chat): drop the duplicate clock on the chat option write - #28591
brennanb2025 wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ➖ Normal Merge Risk: ⚪ Minimal · up to
|
|
Closing: redundant. #28543 already removed the duplicate |
Problem
maindoesn't typecheck, so every PR based on it fails "static analysis and typecheck" and skips its tests.Two separate fixes for the same missing
nowclock both merged: #28571 and the same fix bundled into #28577. They touched different lines, so git combined them without a conflict.writeStructuredAgentSessionOptionnow builds an object literal withnowtwice, which TypeScript rejects.Change
Delete the second entry,
now: () => context.now(), and keepnow: context.nowfrom #28571. The nearby context builders (structured-agent-session-create.ts,structured-agent-session-host-mutations.ts) pass the clock the same way.User-facing change
None. This only makes
maintypecheck again.