Skip to content

fix(i18n): translate 21 new strings to es/fr/ja/ko/zh - #28629

Closed
nwparker wants to merge 1 commit into
mainfrom
nwparker/fix-main-now-and-locales
Closed

nwparker wants to merge 1 commit into
mainfrom
nwparker/fix-main-now-and-locales

Conversation

@nwparker

@nwparker nwparker commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 0 0 0 0
Prod 5 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​170 $\color{#cf222e}{\Huge{\mathbf{−}}}$​35 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​135

Summary

Main's localization coverage check fails: 21 strings added by recent merges (status-bar credits/balance, Session History refusals, the Chat UI setting, the new-workspace agent picker) have no es/fr/ja/ko/zh translations. Every PR is red until this lands. (The typecheck and retired-key breaks this PR first covered were fixed by #28603; this is now translations only.)

Before / after

Before: verify:localization-coverage fails on main and the five language packs show these strings in English. After: the check passes and the strings are translated.

Mechanism

Adds the 21 keys to es/fr/ja/ko/zh, following each catalog's existing terms ("Historial de sesiones", "Chat UI" kept as the product name, "[Opcional]"). Japanese keeps "Agent" as the product term, per the catalog's term rules. {{value0}} placeholders are preserved.

Why this approach

Smallest change that makes main green, with wording matched to what each catalog already uses for the same concepts.

Testing

  • verify-localization-catalogs.mjs (CI lint): all five catalogs verify
  • audit-localization-coverage.mjs --check: passes

@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

📝 Walkthrough

Spanish, French, Japanese, Korean, and Chinese locale files add or update translations for session resume messages, agent settings, Chat UI behavior, workspace creation, and provider usage and balance labels.

Priority: ➖ Normal

Merge Risk: 🟡 Moderate · up to 6d863

The translations look correct, but they break an existing locale test that still expects these strings to be untranslated. Update that test before merging so the test suite passes.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning The description explains the localization gap, user-visible before and after state, implementation approach, rationale, and validation commands. It does not include the required Linked Issue, Visual P… Add an actual linked issue under "Linked Issue". Add before-and-after screenshots, or write N/A with a reason if visual proof is not applicable. Complete the required checklist and relevant template sections.
Passed Passed checks: 4 passed
Check name Status Explanation
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title clearly identifies the main change: translating 21 new localization strings for Spanish, French, Japanese, Korean, and Chinese.
Full details: Description check

Explanation

The description explains the localization gap, user-visible before and after state, implementation approach, rationale, and validation commands. It does not include the required Linked Issue, Visual Proof or explicit N/A, checklist confirmations, or other template sections.

  • Fix all pre-merge checks with AI
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Recent merges added status-bar credit/balance, Session History refusal, Chat UI
and new-workspace agent strings without translations, failing the
localization coverage check on main.

Co-Authored-By: Claude <noreply@anthropic.com>
@nwparker
nwparker force-pushed the nwparker/fix-main-now-and-locales branch from a067fd6 to 6d8636b Compare October 14, 2026 06:48
@nwparker nwparker changed the title fix: restore the option pick's clock and translate 21 new strings fix(i18n): translate 21 new strings to es/fr/ja/ko/zh Oct 14, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1e688f0b-b83b-435d-aa21-f7a566802bcb
📥 Commits

Reviewing files that changed from the base of the PR and between 1c274cc and 6d8636b.

📒 Files selected for processing: 5
  • src/renderer/src/i18n/locales/es.json
  • src/renderer/src/i18n/locales/fr.json
  • src/renderer/src/i18n/locales/ja.json
  • src/renderer/src/i18n/locales/ko.json
  • src/renderer/src/i18n/locales/zh.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 0 remain after this review.

Comment on lines +7354 to +7355
"description": "Abre los agentes nuevos compatibles en Chat UI.",
"copy": "Los agentes nuevos compatibles se abren en el chat estructurado. Los demás agentes se abren en la terminal; los chats existentes siguen disponibles."

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Update the fallback test for these translated catalogs.

src/renderer/src/i18n/native-chat-locales.test.ts expects the Chat UI setting’s description and copy, and the search entry’s description, to be absent for es, ja, ko, and zh. These additions make those assertions fail. Keep the translations and update the test to validate the localized copy.

  • src/renderer/src/i18n/locales/es.json#L7354-L7355: Update the Spanish setting assertions to expect translated description and copy.
  • src/renderer/src/i18n/locales/es.json#L9777-L9777: Update the Spanish search assertion to expect its translated description.
  • src/renderer/src/i18n/locales/ja.json#L7339-L7340: Update the Japanese setting assertions to expect translated description and copy.
  • src/renderer/src/i18n/locales/ja.json#L9799-L9799: Update the Japanese search assertion to expect its translated description.
  • src/renderer/src/i18n/locales/ko.json#L7339-L7340: Update the Korean setting assertions to expect translated description and copy.
  • src/renderer/src/i18n/locales/ko.json#L9762-L9762: Update the Korean search assertion to expect its translated description.
  • src/renderer/src/i18n/locales/zh.json#L7339-L7340: Update the Chinese setting assertions to expect translated description and copy.
  • src/renderer/src/i18n/locales/zh.json#L9762-L9762: Update the Chinese search assertion to expect its translated description.
📍 Affects 4 files
  • src/renderer/src/i18n/locales/es.json#L7354-L7355 (this comment)
  • src/renderer/src/i18n/locales/es.json#L9777-L9777
  • src/renderer/src/i18n/locales/ja.json#L7339-L7340
  • src/renderer/src/i18n/locales/ja.json#L9799-L9799
  • src/renderer/src/i18n/locales/ko.json#L7339-L7340
  • src/renderer/src/i18n/locales/ko.json#L9762-L9762
  • src/renderer/src/i18n/locales/zh.json#L7339-L7340
  • src/renderer/src/i18n/locales/zh.json#L9762-L9762

@nwparker

Copy link
Copy Markdown
Contributor Author

Closing: main is green after #28603, and the missing-translation count was informational, not the failing check. Some of these Chat UI strings are meant to fall back to English (native-chat-locales.test.ts), so they belong in the regular translation batches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant