Repository navigation
Conversation
📝 Walkthrough
Priority: ➖ Normal Merge Risk: 🟡 Moderate · up to
|
Recent merges added status-bar credit/balance, Session History refusal, Chat UI and new-workspace agent strings without translations, failing the localization coverage check on main. Co-Authored-By: Claude <noreply@anthropic.com>
a067fd6 to
6d8636b
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Repository UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
1e688f0b-b83b-435d-aa21-f7a566802bcb
📒 Files selected for processing: 5
src/renderer/src/i18n/locales/es.jsonsrc/renderer/src/i18n/locales/fr.jsonsrc/renderer/src/i18n/locales/ja.jsonsrc/renderer/src/i18n/locales/ko.jsonsrc/renderer/src/i18n/locales/zh.json
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 0 remain after this review.
| "description": "Abre los agentes nuevos compatibles en Chat UI.", | ||
| "copy": "Los agentes nuevos compatibles se abren en el chat estructurado. Los demás agentes se abren en la terminal; los chats existentes siguen disponibles." |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Update the fallback test for these translated catalogs.
src/renderer/src/i18n/native-chat-locales.test.ts expects the Chat UI setting’s description and copy, and the search entry’s description, to be absent for es, ja, ko, and zh. These additions make those assertions fail. Keep the translations and update the test to validate the localized copy.
src/renderer/src/i18n/locales/es.json#L7354-L7355: Update the Spanish setting assertions to expect translateddescriptionandcopy.src/renderer/src/i18n/locales/es.json#L9777-L9777: Update the Spanish search assertion to expect its translateddescription.src/renderer/src/i18n/locales/ja.json#L7339-L7340: Update the Japanese setting assertions to expect translateddescriptionandcopy.src/renderer/src/i18n/locales/ja.json#L9799-L9799: Update the Japanese search assertion to expect its translateddescription.src/renderer/src/i18n/locales/ko.json#L7339-L7340: Update the Korean setting assertions to expect translateddescriptionandcopy.src/renderer/src/i18n/locales/ko.json#L9762-L9762: Update the Korean search assertion to expect its translateddescription.src/renderer/src/i18n/locales/zh.json#L7339-L7340: Update the Chinese setting assertions to expect translateddescriptionandcopy.src/renderer/src/i18n/locales/zh.json#L9762-L9762: Update the Chinese search assertion to expect its translateddescription.
📍 Affects 4 files
src/renderer/src/i18n/locales/es.json#L7354-L7355(this comment)src/renderer/src/i18n/locales/es.json#L9777-L9777src/renderer/src/i18n/locales/ja.json#L7339-L7340src/renderer/src/i18n/locales/ja.json#L9799-L9799src/renderer/src/i18n/locales/ko.json#L7339-L7340src/renderer/src/i18n/locales/ko.json#L9762-L9762src/renderer/src/i18n/locales/zh.json#L7339-L7340src/renderer/src/i18n/locales/zh.json#L9762-L9762
|
Closing: main is green after #28603, and the missing-translation count was informational, not the failing check. Some of these Chat UI strings are meant to fall back to English (native-chat-locales.test.ts), so they belong in the regular translation batches. |
Summary
Main's localization coverage check fails: 21 strings added by recent merges (status-bar credits/balance, Session History refusals, the Chat UI setting, the new-workspace agent picker) have no es/fr/ja/ko/zh translations. Every PR is red until this lands. (The typecheck and retired-key breaks this PR first covered were fixed by #28603; this is now translations only.)
Before / after
Before:
verify:localization-coveragefails on main and the five language packs show these strings in English. After: the check passes and the strings are translated.Mechanism
Adds the 21 keys to es/fr/ja/ko/zh, following each catalog's existing terms ("Historial de sesiones", "Chat UI" kept as the product name, "[Opcional]"). Japanese keeps "Agent" as the product term, per the catalog's term rules.
{{value0}}placeholders are preserved.Why this approach
Smallest change that makes main green, with wording matched to what each catalog already uses for the same concepts.
Testing
verify-localization-catalogs.mjs(CI lint): all five catalogs verifyaudit-localization-coverage.mjs --check: passes