Repository navigation
test(mobile): move the chat view's Stop cases into the turn-status tests - #29355
brennanb2025 wants to merge 3 commits into
Conversation
… file #24093 added a checkout-progress case to the real-Git compatibility suite, which took src/shared/git-binary-compatibility.test.ts to 820 counted lines, over the 800-line limit for test files. Every PR's static analysis now fails on that file. Move the four worktree lifecycle cases into a registered cases file, called at the same point so the shared repository sees the same order.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 3 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
| Description check | |
The description explains the original problem and the intended test-file move, but it states that the PR is superseded and not needed. It omits the required ELI5, Why, Linked Issue, Visual Proof, Test… | Update the description to complete the required template sections, including the linked issue, testing details, visual proof or N/A justification, checklist status, and rationale. If the PR is truly superseded, close it instead of merging i… |
-
Check name Status Explanation Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Title check The title clearly describes the main change: moving the chat view Stop cases into the turn-status tests.
Full details: Description check
-
Explanation
The description explains the original problem and the intended test-file move, but it states that the PR is superseded and not needed. It omits the required ELI5, Why, Linked Issue, Visual Proof, Testing, Review, checklist, and other template sections.
Resolution
Update the description to complete the required template sections, including the linked issue, testing details, visual proof or N/A justification, checklist status, and rationale. If the PR is truly superseded, close it instead of merging it.
- Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 2
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🛠️ Fix failing CI checks: 💡
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
#29099 took mobile/src/session/MobileNativeChatView.test.ts to 806 counted lines, over the 800-line test cap, so the phone app's lint fails on main. Move the four Stop and Stopping cases verbatim into MobileNativeChatView.turn-status.test.ts, which has the same setup, and put the listIds doc comment back above the function it describes.
brennanb2025
changed the title
# Conflicts: # src/shared/git-binary-compatibility.test.ts
brennanb2025
changed the title
Problem
Every PR's Mobile verify check is failing on main right now with one lint error in a file none of them touched:
Phone test files are capped at 800 counted lines (blank lines and comments excluded). #29099 (open each chat at its newest message) added a case to this file and took it to 806.
(This PR also covered the same failure in
src/shared/git-binary-compatibility.test.ts. #29357 fixed that one on main first, so that half is dropped and main's version kept.)Change
Test-only, with no behavior change. No test is removed or edited; cases only move.
The four Stop and "Stopping…" cases move verbatim from
MobileNativeChatView.test.tsintoMobileNativeChatView.turn-status.test.ts, which uses the same test setup (same mocked composer, render helpers and props). A doc comment forlistIds()had drifted above one of those cases, and it goes back above the function. The file drops to 878 lines, under the counted cap.