Skip to content

test(ssh): run the relay-era CLI tests that open a real store in the Node runtime - #29606

Closed
nwparker wants to merge 1 commit into
mainfrom
nwparker/register-legacy-relay-cli-sqlite-tests
Closed

nwparker wants to merge 1 commit into
mainfrom
nwparker/register-legacy-relay-cli-sqlite-tests

Conversation

@nwparker

@nwparker nwparker commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 0 0 0 0
Prod 1 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​3 0 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​3

ELI5

Main's unit tests are red for every PR because three new test files open a real SQLite store but aren't on the list of tests that must run under Node. This adds them to that list.

What Changed

config/scripts/vitest-sqlite-runtime-files.mjs now lists:

  • src/main/ssh/legacy-relay-bridge/legacy-relay-cli-call-limits.test.ts
  • src/main/ssh/legacy-relay-bridge/legacy-relay-cli-legacy-records.test.ts
  • src/main/ssh/legacy-relay-bridge/legacy-relay-cli-server.test.ts

config/scripts/vitest-sqlite-runtime-boundary.test.ts requires every test that opens a real SQLite store to run in the Node runtime project. These three came in with the relay-era orchestration work in #29571 and #29596 (STA-10765, thanks!) without being listed, so the boundary test fails on unit shard 3 for everyone.

Why

This is the smallest fix: it adds the files to the existing list, exactly as other SQLite-backed tests are registered. No test or product code changes.

Linked Issue

N/A (maintainer; main CI breakage after #29571 / #29596).

Visual Proof

N/A: CI configuration only.

Testing

  • I manually tested these changes locally

  • Automated tests added/updated, or explained why not below

  • vitest-sqlite-runtime-boundary.test.ts passes (it failed on main).

  • The three relay-era CLI test files pass in the Node runtime: 31 tests.

AI Disclosure

Review

Agent skill upstream boundary

  • Not applicable, or this change copies or mechanically translates no upstream skill-installer source, tests, fixtures, registry entries, path tables, comments, or documentation.

Notes

CI-only. It touches no product code and no user paths.

Checklist

  • This PR is small and focused
  • I explained what changed and why (ELI5, the user-facing before/after, the mechanism, and why over the alternatives)
  • Before/after screenshots or videos attached for UI changes, or N/A with reason
  • Self-reviewed for correctness, security, and performance
  • Cross-platform, SSH/remote, and path/shortcut impact considered (or N/A)
  • pnpm lint, pnpm typecheck, pnpm test, and pnpm build pass (or CI will cover; local preferred)

@coderabbitai

coderabbitai Bot commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 37a8bfca-18b7-4f30-9b51-d9b8f2d6e43f
📥 Commits

Reviewing files that changed from the base of the PR and between bb441d1 and 35f8e3d.

📒 Files selected for processing: 1
  • config/scripts/vitest-sqlite-runtime-files.mjs

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review.

📝 Walkthrough

The SQLite runtime include list now includes the legacy relay CLI call-limits, legacy-records, and server test files.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 35f8e

The change registers the three SQLite-backed tests for the Node runtime without an identified impact on other test selection. No actionable merge risk remains.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly identifies the SSH test change and explains that relay-era CLI tests using a real store will run in the Node runtime.
Description check Passed The description follows the repository template and explains the problem, changed files, rationale, testing, visual proof status, and checklist items. It also documents the maintainer exception for th…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description follows the repository template and explains the problem, changed files, rationale, testing, visual proof status, and checklist items. It also documents the maintainer exception for the linked issue.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nwparker

Copy link
Copy Markdown
Contributor Author

Closing as a duplicate: #29595 (1855ba4) landed the same three entries in config/scripts/vitest-sqlite-runtime-files.mjs before this merged. The pre-merge check of main caught it.

@nwparker nwparker closed this Oct 16, 2026
@nwparker
nwparker deleted the nwparker/register-legacy-relay-cli-sqlite-tests branch October 16, 2026 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant