Repository navigation
fix(native-chat): keep the session host under its line limit - #29869
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to
|
Problem
Static analysis fails on main, and so on every open PR:
src/main/native-chat/agent-session-wire/structured-agent-session-host.tshas 302 countable lines, over the 300-line limit. Two PRs each added lines to this file and passed CI on their own: #27925 (wait for agent readiness) and #29121 (keep pending chat decisions available outside loaded history). Merged together, they pushed it over the limit. #29121 was merged without first re-running CI on a main that already had #27925.What changes
Nothing a user sees. The two delegates that settle a late dispatch and release unanswered dispatches move from the session host class into
structuredAgentSessionMutationDelegates, which already builds the other mutation delegates from the same mutation context. The host keeps the same public names (settleLateDispatch,releaseUnansweredDispatches), so callers don't change. The host drops to 297 lines and the mutations file goes to 270. No line-limit check is disabled.Notes
Author: @BrennanKB5