Repository navigation
refactor(ssh): group system-ssh transport, ssh config and remote exec into their own folders - #30355
Merged
Merged
Conversation
… into ssh/{system-transport,config,remote-exec}/
git mv plus import, vi.mock and path-literal rewrites; one e2e route regex follows the moved
dynamic-forward process.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
src/main/sshis still mostly one flat folder. This PR sorts three more groups of files into subfolders:sshbinary transport;Nothing the app does changes.
What Changed
git mv, names unchanged:src/main/ssh/system-ssh-*(27 files) →src/main/ssh/system-transport/ssh-config-*,ssh-g-config-resolution,ssh-known-hosts*andvscode-ssh-authority(18 files) →src/main/ssh/config/remote-exec-*,remote-host-*andremote-frame-protocol(10 files) →src/main/ssh/remote-exec/vi.mockpaths are updated in 273 importers. Most of them are the persistence tests that mockssh-config-parser; the rest sit inipc,wsl,managed-server,agent-hooks,github,browser,wsl-guestandtests/e2e. Path literals inreliability-gates.jsoncandci-shard-timings.jsonare updated too.ssh-browser-network-execution-routee2e route now namesssh/system-transport/system-ssh-dynamic-forward-process.ts. At the new path it selects the same specs as before. No other route or workflow named these files. The host-lane workflows'src/main/ssh/remote-*glob covered only the deploy primitives, which refactor(managed-server): move the managed server's install and deploy code into src/main/managed-server/install/ #30335 already moved.git diff -Mshows every moved file as a rename. The only edits inside them are../import depth.Why
This implements round 2's folder plan (§4.2, M5). It takes
src/main/sshcloser to "one concept per folder". What's left at the top level is mainly the connection cluster (ssh-connection*,ssh-target*), which is M8 and needs a freeze window.Linked Issue
N/A (SSH hardening round 2, S11/M5).
Visual Proof
N/A: a pure file move.
Testing
typecheck:ci: clean.src/main/ssh,src/main/managed-server,ipc/ssh*,src/main/wsl,agent-hooks,src/main/browser, plus every changed test file outsidesrc/main/ssh, which includes the persistence tests with the rewrittenssh-config-parsermock.