Repository navigation
refactor(ipc): group SSH and runtime-environment IPC handlers into ipc/ssh/ and ipc/runtime-environments/ - #30362
Merged
Merged
Conversation
…c/ssh/ and ipc/runtime-environments/ git mv plus import, vi.mock and path-literal rewrites; e2e route regexes and the Windows host lane filter follow the moved handlers.
Contributor
📝 Walkthrough
Priority: ⬇️ Low Merge Risk: 🔵 Low · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Description check |  |
The description explains the change, rationale, affected paths, visual impact, and testing. However, it does not provide the required linked issue and omits several template sections, including Review… | Add an actual issue reference after "Fixes #" or provide the required repository-approved issue link. Complete the missing template sections, including Review, Notes, Agent skill upstream boundary, and Checklist. Add the AI Disclosure secti… |
| Docstring Coverage |  |
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 50 files. (153 skipped:… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Title check The title clearly summarizes the primary change: grouping SSH and runtime-environment IPC handlers into dedicated subdirectories. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Description check
-
Explanation
The description explains the change, rationale, affected paths, visual impact, and testing. However, it does not provide the required linked issue and omits several template sections, including Review, Notes, the Agent skill upstream boundary, and the Checklist.
Resolution
Add an actual issue reference after "Fixes #" or provide the required repository-approved issue link. Complete the missing template sections, including Review, Notes, Agent skill upstream boundary, and Checklist. Add the AI Disclosure section if the contributor is external.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 50 files. (153 skipped: 6 unsupported, 147 over the file limit.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
- Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Repository UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
56adb79e-903a-4959-9b3b-51b021d3d1ba
📒 Files selected for processing: 215
.github/workflows/ssh-windows-hosts.ymlconfig/legacy-relay-compat-tags-baseline.txtconfig/legacy-relay-importers-baseline.txtconfig/main-layout-writer-baseline.txtconfig/reliability-gates.jsoncconfig/scripts/check-compat-boundary-imports.mjsconfig/scripts/ci-shard-timings.jsonconfig/scripts/pr-e2e-route-contracts.test.mjsconfig/scripts/pr-e2e-source-routing.mjsconfig/scripts/vitest-node-runtime-files.mjsconfig/scripts/vitest-sqlite-runtime-files.mjssrc/main/ai-vault/runtime-session-scanner.test.tssrc/main/ai-vault/runtime-session-scanner.tssrc/main/ai-vault/runtime-session-search-call.test.tssrc/main/ai-vault/runtime-session-search-call.tssrc/main/browser/doc-preview-file-reader.test.tssrc/main/browser/doc-preview-file-reader.tssrc/main/ephemeral-vm-runtime-ssh.test.tssrc/main/ephemeral-vm-runtime-ssh.tssrc/main/ipc/agent-session-attachment-upload.test.tssrc/main/ipc/agent-session-attachment-upload.tssrc/main/ipc/ai-vault-host-leg-cache-retention.test.tssrc/main/ipc/ai-vault-search.test.tssrc/main/ipc/ai-vault-unresolved-owner.test.tssrc/main/ipc/browser.tssrc/main/ipc/desktop-browser-bridge-wiring.test.tssrc/main/ipc/desktop-browser-bridge-wiring.tssrc/main/ipc/ephemeral-vm-managed-ssh.test.tssrc/main/ipc/ephemeral-vm-runtime-handlers.tssrc/main/ipc/ephemeral-vm.test.tssrc/main/ipc/managed-host-status-publication.test.tssrc/main/ipc/register-core-handlers/register-core-handlers.test.tssrc/main/ipc/register-core-handlers/register-core-handlers.tssrc/main/ipc/runtime-environments/managed-orcad-actions.tssrc/main/ipc/runtime-environments/orcad-delta-move-handlers.test.tssrc/main/ipc/runtime-environments/orcad-delta-move-handlers.tssrc/main/ipc/runtime-environments/orcad-leave-behind-handlers.tssrc/main/ipc/runtime-environments/orcad-runtime-conversion-handlers.test.tssrc/main/ipc/runtime-environments/orcad-runtime-conversion-handlers.tssrc/main/ipc/runtime-environments/orcad-runtime-lifecycle-handlers.test.tssrc/main/ipc/runtime-environments/orcad-runtime-lifecycle-handlers.tssrc/main/ipc/runtime-environments/orcad-runtime-maintenance-handlers.test.tssrc/main/ipc/runtime-environments/orcad-runtime-maintenance-handlers.tssrc/main/ipc/runtime-environments/orcad-ssh-provisioning-handlers.test.tssrc/main/ipc/runtime-environments/orcad-ssh-provisioning-handlers.tssrc/main/ipc/runtime-environments/runtime-environment-abortable-requests.tssrc/main/ipc/runtime-environments/runtime-environment-browser-client-host-handler.test.tssrc/main/ipc/runtime-environments/runtime-environment-browser-client-host-handler.tssrc/main/ipc/runtime-environments/runtime-environment-call-queue.tssrc/main/ipc/runtime-environments/runtime-environment-capability-evidence.test.tssrc/main/ipc/runtime-environments/runtime-environment-capability-evidence.tssrc/main/ipc/runtime-environments/runtime-environment-cli-removal-routing.test.tssrc/main/ipc/runtime-environments/runtime-environment-connectivity-handlers.tssrc/main/ipc/runtime-environments/runtime-environment-diagnostics-broadcast.test.tssrc/main/ipc/runtime-environments/runtime-environment-diagnostics-broadcast.tssrc/main/ipc/runtime-environments/runtime-environment-federated-read-routing.test.tssrc/main/ipc/runtime-environments/runtime-environment-federated-read-transport.bench.test.tssrc/main/ipc/runtime-environments/runtime-environment-handler-channels.tssrc/main/ipc/runtime-environments/runtime-environment-host-dispatch.test.tssrc/main/ipc/runtime-environments/runtime-environment-host-key.test.tssrc/main/ipc/runtime-environments/runtime-environment-host-key.tssrc/main/ipc/runtime-environments/runtime-environment-host-service-ops.tssrc/main/ipc/runtime-environments/runtime-environment-managed-host-disconnect.test.tssrc/main/ipc/runtime-environments/runtime-environment-managed-tunnel.test.tssrc/main/ipc/runtime-environments/runtime-environment-managed-tunnel.tssrc/main/ipc/runtime-environments/runtime-environment-manual-disconnect.tssrc/main/ipc/runtime-environments/runtime-environment-mobile-relay-hosts.test.tssrc/main/ipc/runtime-environments/runtime-environment-mobile-relay-hosts.tssrc/main/ipc/runtime-environments/runtime-environment-pairing-verification.tssrc/main/ipc/runtime-environments/runtime-environment-preference.test.tssrc/main/ipc/runtime-environments/runtime-environment-preference.tssrc/main/ipc/runtime-environments/runtime-environment-recovery-handler.test.tssrc/main/ipc/runtime-environments/runtime-environment-recovery-handler.tssrc/main/ipc/runtime-environments/runtime-environment-removal-cleanup.test.tssrc/main/ipc/runtime-environments/runtime-environment-removal-cleanup.tssrc/main/ipc/runtime-environments/runtime-environment-removal-storage.test.tssrc/main/ipc/runtime-environments/runtime-environment-repair-handler.tssrc/main/ipc/runtime-environments/runtime-environment-request-connections.test.tssrc/main/ipc/runtime-environments/runtime-environment-request-connections.tssrc/main/ipc/runtime-environments/runtime-environment-retry-connections-probe.test.tssrc/main/ipc/runtime-environments/runtime-environment-revision-guard.test.tssrc/main/ipc/runtime-environments/runtime-environment-revision-guard.tssrc/main/ipc/runtime-environments/runtime-environment-session-reconcile.test.tssrc/main/ipc/runtime-environments/runtime-environment-session-reconcile.tssrc/main/ipc/runtime-environments/runtime-environment-session-tabs-delta-decoding.test.tssrc/main/ipc/runtime-environments/runtime-environment-session-tabs-delta-decoding.tssrc/main/ipc/runtime-environments/runtime-environment-session-tabs-delta.integration.test.tssrc/main/ipc/runtime-environments/runtime-environment-shared-control-answers.tssrc/main/ipc/runtime-environments/runtime-environment-shared-control-support.tssrc/main/ipc/runtime-environments/runtime-environment-status-connection.test.tssrc/main/ipc/runtime-environments/runtime-environment-status-diagnostics.tssrc/main/ipc/runtime-environments/runtime-environment-status-owner.tssrc/main/ipc/runtime-environments/runtime-environment-status-probe.tssrc/main/ipc/runtime-environments/runtime-environment-status-recovery.test.tssrc/main/ipc/runtime-environments/runtime-environment-status-retirement.test.tssrc/main/ipc/runtime-environments/runtime-environment-subscription-handlers.tssrc/main/ipc/runtime-environments/runtime-environment-subscription-identity.test.tssrc/main/ipc/runtime-environments/runtime-environment-subscription-layout-recording.test.tssrc/main/ipc/runtime-environments/runtime-environment-support-routing.test.tssrc/main/ipc/runtime-environments/runtime-environment-support-routing.tssrc/main/ipc/runtime-environments/runtime-environment-tailscale-response.tssrc/main/ipc/runtime-environments/runtime-environment-transport-generation.test.tssrc/main/ipc/runtime-environments/runtime-environment-transport-generation.tssrc/main/ipc/runtime-environments/runtime-environment-transport-routing-tailscale-hint.test.tssrc/main/ipc/runtime-environments/runtime-environment-transport-routing.tssrc/main/ipc/runtime-environments/runtime-environment-unreachable-hint.test.tssrc/main/ipc/runtime-environments/runtime-environment-unreachable-hint.tssrc/main/ipc/runtime-environments/runtime-environment-usage-record.tssrc/main/ipc/runtime-environments/runtime-environments-call-routing.test.tssrc/main/ipc/runtime-environments/runtime-environments-capability-cache.test.tssrc/main/ipc/runtime-environments/runtime-environments-ipc-test-harness.tssrc/main/ipc/runtime-environments/runtime-environments-pairing.test.tssrc/main/ipc/runtime-environments/runtime-environments-repair.test.tssrc/main/ipc/runtime-environments/runtime-environments-status-diagnostics.test.tssrc/main/ipc/runtime-environments/runtime-environments-subscription-lifecycle.test.tssrc/main/ipc/runtime-environments/runtime-environments-subscription-routing.test.tssrc/main/ipc/runtime-environments/runtime-environments-subscription-teardown.test.tssrc/main/ipc/runtime-environments/runtime-environments.tssrc/main/ipc/runtime-upload-file-stream.test.tssrc/main/ipc/runtime-upload-file-stream.tssrc/main/ipc/runtime-upload-slice-boundaries.test.tssrc/main/ipc/runtime-upload-temp-sweep.test.tssrc/main/ipc/runtime-upload-temp-sweep.tssrc/main/ipc/settings.tssrc/main/ipc/skill-cloud-ipc-handlers.test.tssrc/main/ipc/skill-cloud-ipc-handlers.tssrc/main/ipc/skill-install-management-ipc-handlers.test.tssrc/main/ipc/skill-install-management-ipc-handlers.tssrc/main/ipc/ssh/ssh-app-shutdown.test.tssrc/main/ipc/ssh/ssh-browse.test.tssrc/main/ipc/ssh/ssh-browse.tssrc/main/ipc/ssh/ssh-connect-attempt-registry.tssrc/main/ipc/ssh/ssh-connect-decision-cancellation.test.tssrc/main/ipc/ssh/ssh-connect-flow.tssrc/main/ipc/ssh/ssh-connection-handlers.tssrc/main/ipc/ssh/ssh-connection-state-callbacks.tssrc/main/ipc/ssh/ssh-credential-cancel.test.tssrc/main/ipc/ssh/ssh-disconnect-cancellation.test.tssrc/main/ipc/ssh/ssh-handler-reregistration.test.tssrc/main/ipc/ssh/ssh-host-launch-session-note.test.tssrc/main/ipc/ssh/ssh-host-launch-session-note.tssrc/main/ipc/ssh/ssh-host-server-connect.tssrc/main/ipc/ssh/ssh-host-server-decision-failure.test.tssrc/main/ipc/ssh/ssh-host-server-on-connect-wiring.test.tssrc/main/ipc/ssh/ssh-host-server-on-connect-wiring.tssrc/main/ipc/ssh/ssh-host-sleep-reconnect.test.tssrc/main/ipc/ssh/ssh-host-sleep-reconnect.tssrc/main/ipc/ssh/ssh-host-user-disconnect.test.tssrc/main/ipc/ssh/ssh-host-user-disconnect.tssrc/main/ipc/ssh/ssh-ipc-context.tssrc/main/ipc/ssh/ssh-ipc-mock-shapes.tssrc/main/ipc/ssh/ssh-ipc-module-mocks.tssrc/main/ipc/ssh/ssh-ipc-test-harness.tssrc/main/ipc/ssh/ssh-managed-host-port-forward-lifecycle.test.tssrc/main/ipc/ssh/ssh-managed-port-forward-restore.tssrc/main/ipc/ssh/ssh-managed-server-unlink-broadcast.test.tssrc/main/ipc/ssh/ssh-passphrase.test.tssrc/main/ipc/ssh/ssh-passphrase.tssrc/main/ipc/ssh/ssh-port-forward-handlers.tssrc/main/ipc/ssh/ssh-port-forward-persistence.tssrc/main/ipc/ssh/ssh-port-forward-restore.test.tssrc/main/ipc/ssh/ssh-renderer-broadcast.tssrc/main/ipc/ssh/ssh-session-teardown.tssrc/main/ipc/ssh/ssh-shutdown-drain.tssrc/main/ipc/ssh/ssh-sign-in-requirement.test.tssrc/main/ipc/ssh/ssh-sign-in-requirement.tssrc/main/ipc/ssh/ssh-state-broadcast-fanout.test.tssrc/main/ipc/ssh/ssh-target-crud-handlers-ownership.test.tssrc/main/ipc/ssh/ssh-target-crud-handlers.tssrc/main/ipc/ssh/ssh-target-lifecycle-queue.tssrc/main/ipc/ssh/ssh-target-registry.test.tssrc/main/ipc/ssh/ssh-test-connection-probe-registry.test.tssrc/main/ipc/ssh/ssh-test-probe-presence.test.tssrc/main/ipc/ssh/ssh.test.tssrc/main/ipc/ssh/ssh.tssrc/main/ipc/wsl-host-gate-off.test.tssrc/main/ipc/wsl-host-handlers.tssrc/main/managed-server/lifecycle/orcad-managed-tunnel.tssrc/main/managed-server/lifecycle/orcad-runtime-conversion-wiring.tssrc/main/managed-server/lifecycle/orcad-runtime-conversion.tssrc/main/managed-server/lifecycle/orcad-runtime-deployment.tssrc/main/managed-server/lifecycle/orcad-runtime-status.tssrc/main/skills/skill-client-mediated-transfer-cancellation.test.tssrc/main/skills/skill-client-mediated-transfer.test.tssrc/main/skills/skill-client-mediated-transfer.tssrc/main/skills/skill-cloud-grant-installation.test.tssrc/main/skills/skill-cloud-grant-installation.tssrc/main/skills/skill-remote-error-category-parity.test.tssrc/main/skills/skill-remote-install-service.test.tssrc/main/skills/skill-remote-install-service.tssrc/main/skills/skill-runtime-capability.test.tssrc/main/skills/skill-runtime-capability.tssrc/main/ssh/legacy-relay/ssh-relay-version-mismatch-error.tssrc/main/ssh/orcad-migration-delta-move.test.tssrc/main/ssh/orcad-migration-delta-snapshot.test.tssrc/main/ssh/orcad-migration-repository-link.test.tssrc/main/ssh/orcad-runtime-maintenance.tssrc/main/ssh/orcad-ssh-provisioning.tssrc/main/ssh/runtime-ssh-access.tssrc/main/ssh/ssh-connection-reconnect-ladder.test.tssrc/main/startup/headless-serve-ssh-registration.test.tssrc/main/startup/headless-serve-ssh-registration.tssrc/main/startup/main-process-quit.tssrc/main/startup/main-process-runtime-launch-activation.test.tssrc/main/startup/main-process-runtime-launch.tssrc/main/startup/main-process-runtime-service.tssrc/main/window/attach-main-window-services.test.tssrc/main/window/attach-main-window-services.tssrc/main/window/clipboard-agent-session-attachment-paste.test.tssrc/main/window/clipboard-ipc-handlers.test.tssrc/main/window/clipboard-runtime-image-upload.tssrc/main/window/clipboard-runtime-owned-ssh-paste.test.tssrc/renderer/src/components/browser-pane/stream-remote/remote-browser-stream-lifecycle-test-harness.tssrc/renderer/src/components/browser-pane/stream-remote/remote-browser-stream-lifecycle.test.tssrc/renderer/src/components/browser-pane/stream-remote/remote-browser-stream-lifecycle.ts
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
| "runner": "local", | ||
| "platform": "macos", | ||
| "command": "pnpm exec vitest run --config config/vitest.config.ts src/main/ipc/runtime-environments-subscription-teardown.test.ts", | ||
| "command": "pnpm exec vitest run --config config/vitest.config.ts src/main/ipc/runtime-environments/runtime-environments-subscription-teardown.test.ts", |
Contributor
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
git diff 658953dc23b90d3c637a20951669089f3ed04df8 e6798d4330c358e3ba5915443fd2258376fe3820 -- config/reliability-gates.jsonc | rg -n -C 5 '5318|evidenceRuns|currentCommand|subscription-teardown|terminal-hidden|ssh.test.ts'
sed -n '5300,5325p;10662,10684p;12120,12179p;18768,18783p' config/reliability-gates.jsonc
rg -n 'evidenceRuns|currentCommand' config/scripts/check-reliability-gates.mjs | head -60Repository: stablyai/orca
Length of output: 42140
Preserve historical commands in dated evidence records.
The evidenceRuns[].command fields record the commands that produced the dated results. Keep those commands unchanged. Use relocated paths in commands, testFiles, and currentCommand where present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
src/main/ipchad about 130 SSH and runtime-environment IPC handler files sitting loose among everything else. This PR moves them into two subfolders,ipc/ssh/andipc/runtime-environments/. Nothing the app does changes.What Changed
src/main/ipc/ssh.ts,ssh.test.tsand everysrc/main/ipc/ssh-*file (47 files) move tosrc/main/ipc/ssh/withgit mv. Names are unchanged.src/main/ipc/runtime-environment*,orcad-*andmanaged-orcad-actions*(85 files) move tosrc/main/ipc/runtime-environments/withgit mv. Names are unchanged.vi.mockpaths in 69 importers;reliability-gates.jsonc,ci-shard-timings.jsonand the compat-boundary importer list;src/main/ipc/ssh-host-server-*.tspath filter.ssh/orruntime-environments/segment.managed-orcad-actions.tsgains 6 specs, because the remote fallback route from ci(e2e): start the managed-SSH lane for remote product changes no route names #30210 now catches it underipc/runtime-environments/.git diff -Mshows every moved file as a rename. The only edits inside them are their../import depth.Why
This is round 2's folder plan (§4.2, M6): one concept per folder, so the SSH and runtime-environment IPC surfaces sit together and apart from the rest of
ipc/.Linked Issue
N/A (SSH hardening round 2, S11/M6).
Visual Proof
N/A: a pure file move.
Testing
typecheck:ci: clean.src/main/ipc,src/main/ssh,src/main/managed-serverandsrc/main/wsl, plus the e2e routing, orcad scope and compat-boundary config tests and every other changed test file, single worker: 1,092 files, 11,415 tests, all passing.