Repository navigation
chore(ratchet): prune the tabs-group-actions layout-writer baseline - #30869
Conversation
#29150 removed one layout write from tabs-group-actions.ts without pruning its baseline entry, so every PR's static analysis fails with 'baseline still allows 13'.
…ilder Also carries main's one-line layout-writer baseline prune (#30869) so this branch's static analysis can run until that lands.
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 Walkthrough
Priority: ⬇️ Low Merge Risk: 🔵 Low · up to
|
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Repository UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
85e6710f-140d-4e9c-8ccc-eb84458059de
📒 Files selected for processing: 1
config/renderer-layout-writer-baseline.txt
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review.
| 11 src/renderer/src/store/slices/tabs/tabs-drop-actions.ts | ||
| 4 src/renderer/src/store/slices/tabs/tabs-focus-actions.ts | ||
| 13 src/renderer/src/store/slices/tabs/tabs-group-actions.ts | ||
| 12 src/renderer/src/store/slices/tabs/tabs-group-actions.ts |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
set -u
printf '%s\n' '--- changed files and diff ---'
git diff --stat bd7633f6eb5e468c5220be77909071cddc466af4 a6664e2df9df737eaff1fd9e87f9417b03b4a985
git diff --unified=20 bd7633f6eb5e468c5220be77909071cddc466af4 a6664e2df9df737eaff1fd9e87f9417b03b4a985 -- config/renderer-layout-writer-baseline.txt config/scripts/check-layout-writer-ratchets.mjs .github 2>/dev/null || true
printf '%s\n' '--- checker excerpt ---'
nl -ba config/scripts/check-layout-writer-ratchets.mjs | sed -n '390,475p'
printf '%s\n' '--- checker references ---'
rg -n -F --glob '!node_modules/**' -e 'check-layout-writer-ratchets' -e 'renderer-layout-writer-baseline' .github config package.json 2>/dev/null || test "$?" -eq 1
printf '%s\n' '--- relevant baseline entries ---'
nl -ba config/renderer-layout-writer-baseline.txt | sed -n '84,96p'Repository: stablyai/orca
Length of output: 8321
🏁 Script executed:
set -u
printf '%s\n' '--- PR workflow context ---'
nl -ba .github/workflows/pr.yml | sed -n '370,410p'
printf '%s\n' '--- checker definitions and ratchet configuration ---'
nl -ba config/scripts/check-layout-writer-ratchets.mjs | sed -n '1,175p'
nl -ba config/scripts/check-layout-writer-ratchets.mjs | sed -n '330,402p'
printf '%s\n' '--- target source layout-write calls ---'
rg -n -F --glob 'tabs-group-actions.ts' -e 'layout' -e 'write' src/renderer/src/store/slices/tabs/tabs-group-actions.ts || test "$?" -eq 1Repository: stablyai/orca
Length of output: 14233
Identify the failing CI step before relying on this baseline change.
The layout-writer check warns when the count is below the baseline and fails only when the count grows. Therefore, a count of 12 against the old baseline of 13 cannot fail this step. This change removes the warning, but it does not explain a CI failure. Identify the failing step and explain how this edit resolves it.
Problem
Every pull request's "static analysis and typecheck" job currently fails on main with:
src/renderer/src/store/slices/tabs/tabs-group-actions.ts: 12 renderer layout write(s), baseline still allows 13. Run: pnpm check:layout-writer-ratchets --prune#29150 removed one layout write from
tabs-group-actions.tsbut left its baseline entry at 13, and the ratchet fails when a baseline allows more than the file uses. Six open PRs checked today (#30854 to #30860) all fail on this line.Change
Prune that one baseline entry from 13 to 12. No code changes, no behavior change for users.
Testing
CI's static-analysis job on this PR is the check.
Author: @BrennanKB5