Skip to content

chore(ratchet): prune the tabs-group-actions layout-writer baseline - #30869

Merged
brennanb2025 merged 2 commits into
mainfrom
brennanb2025/prune-tabs-group-layout-baseline
Oct 20, 2026
Merged

brennanb2025 merged 2 commits into
mainfrom
brennanb2025/prune-tabs-group-layout-baseline

Conversation

@brennanb2025

@brennanb2025 brennanb2025 commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 0 0 0 0
Prod 1 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​1 $\color{#cf222e}{\Huge{\mathbf{−}}}$​1 0

Problem

Every pull request's "static analysis and typecheck" job currently fails on main with:

src/renderer/src/store/slices/tabs/tabs-group-actions.ts: 12 renderer layout write(s), baseline still allows 13. Run: pnpm check:layout-writer-ratchets --prune

#29150 removed one layout write from tabs-group-actions.ts but left its baseline entry at 13, and the ratchet fails when a baseline allows more than the file uses. Six open PRs checked today (#30854 to #30860) all fail on this line.

Change

Prune that one baseline entry from 13 to 12. No code changes, no behavior change for users.

Testing

CI's static-analysis job on this PR is the check.

Author: @BrennanKB5

#29150 removed one layout write from tabs-group-actions.ts without pruning
its baseline entry, so every PR's static analysis fails with 'baseline still
allows 13'.
brennanb2025 added a commit that referenced this pull request Oct 19, 2026
…ilder

Also carries main's one-line layout-writer baseline prune (#30869) so this
branch's static analysis can run until that lands.
@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 613267dc-7324-44e2-8fc1-3dbb4c39970a
📥 Commits

Reviewing files that changed from the base of the PR and between a6664e2 and 1c92c67.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

The recorded write-count limit for tabs-group-actions.ts changed from 13 to 12.

Priority: ⬇️ Low

Merge Risk: 🔵 Low · up to a6664

The baseline now matches the recorded write count, but the available checker evidence does not show that the previous count caused a CI failure. Confirm the failing check before relying on this change as its fix.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning The description explains the problem, change, and testing plan, but it does not follow the required template. It omits ELI5, Linked Issue, Visual Proof with an explicit N/A reason, AI Disclosure, Revi… Update the description to include all required template sections. Add the linked issue, state N/A with a reason for Visual Proof because there is no behavior or UI change, complete the testing and checklist items, and address the remaining …
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly and concisely describes the baseline pruning change.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Description check

Explanation

The description explains the problem, change, and testing plan, but it does not follow the required template. It omits ELI5, Linked Issue, Visual Proof with an explicit N/A reason, AI Disclosure, Review, Agent skill upstream boundary, Notes, and Checklist sections.

Resolution

Update the description to include all required template sections. Add the linked issue, state N/A with a reason for Visual Proof because there is no behavior or UI change, complete the testing and checklist items, and address the remaining required sections or mark them not applicable.

✨ Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 85e6710f-140d-4e9c-8ccc-eb84458059de
📥 Commits

Reviewing files that changed from the base of the PR and between bd7633f and a6664e2.

📒 Files selected for processing: 1
  • config/renderer-layout-writer-baseline.txt

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review.

11 src/renderer/src/store/slices/tabs/tabs-drop-actions.ts
4 src/renderer/src/store/slices/tabs/tabs-focus-actions.ts
13 src/renderer/src/store/slices/tabs/tabs-group-actions.ts
12 src/renderer/src/store/slices/tabs/tabs-group-actions.ts

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

🔎 Supported by static analysis

🏁 Script executed:

set -u
printf '%s\n' '--- changed files and diff ---'
git diff --stat bd7633f6eb5e468c5220be77909071cddc466af4 a6664e2df9df737eaff1fd9e87f9417b03b4a985
git diff --unified=20 bd7633f6eb5e468c5220be77909071cddc466af4 a6664e2df9df737eaff1fd9e87f9417b03b4a985 -- config/renderer-layout-writer-baseline.txt config/scripts/check-layout-writer-ratchets.mjs .github 2>/dev/null || true
printf '%s\n' '--- checker excerpt ---'
nl -ba config/scripts/check-layout-writer-ratchets.mjs | sed -n '390,475p'
printf '%s\n' '--- checker references ---'
rg -n -F --glob '!node_modules/**' -e 'check-layout-writer-ratchets' -e 'renderer-layout-writer-baseline' .github config package.json 2>/dev/null || test "$?" -eq 1
printf '%s\n' '--- relevant baseline entries ---'
nl -ba config/renderer-layout-writer-baseline.txt | sed -n '84,96p'

Repository: stablyai/orca

Length of output: 8321


🏁 Script executed:

set -u
printf '%s\n' '--- PR workflow context ---'
nl -ba .github/workflows/pr.yml | sed -n '370,410p'
printf '%s\n' '--- checker definitions and ratchet configuration ---'
nl -ba config/scripts/check-layout-writer-ratchets.mjs | sed -n '1,175p'
nl -ba config/scripts/check-layout-writer-ratchets.mjs | sed -n '330,402p'
printf '%s\n' '--- target source layout-write calls ---'
rg -n -F --glob 'tabs-group-actions.ts' -e 'layout' -e 'write' src/renderer/src/store/slices/tabs/tabs-group-actions.ts || test "$?" -eq 1

Repository: stablyai/orca

Length of output: 14233


Identify the failing CI step before relying on this baseline change.

The layout-writer check warns when the count is below the baseline and fails only when the count grows. Therefore, a count of 12 against the old baseline of 13 cannot fail this step. This change removes the warning, but it does not explain a CI failure. Identify the failing step and explain how this edit resolves it.

@brennanb2025
brennanb2025 merged commit a817602 into main Oct 20, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant