Skip to content

feat(settings): explain beside Antigravity's sign-in why the agy CLI login doesn't carry over - #30909

Closed
brennanb2025 wants to merge 3 commits into
mainfrom
brennanb2025/antigravity-signin-info-tooltip
Closed

brennanb2025 wants to merge 3 commits into
mainfrom
brennanb2025/antigravity-signin-info-tooltip

Conversation

@brennanb2025

@brennanb2025 brennanb2025 commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

ELI5

People who already signed in to Antigravity with the agy command in their terminal see a "Sign in" button for Antigravity chats and wonder why they have to sign in again. There's now a small info button beside that Sign in button. Hovering it explains: "Antigravity chats have their own sign-in. Signing in to the agy CLI doesn't sign you in here."

What Changed

Before: Settings › Chat › Providers (under Antigravity) and Settings › Accounts › Antigravity ("Antigravity chats") showed a Sign in / Change account / Retry sign-in button with nothing to explain why an agy terminal login doesn't count.

After: both places show an ⓘ button just left of that button. Its tooltip says "Antigravity chats have their own sign-in. Signing in to the agy CLI doesn't sign you in here." The ⓘ is hidden while a sign-in is running (the row then shows Copy link and Cancel instead).

Mechanism: one new AntigravityChatSignInInfo component in AntigravityChatSignInRow.tsx (a ghost icon button with a tooltip), placed next to the action button in both sign-in layouts. New copy is translated in all six locales.

Why

Users assume their agy CLI login carries over to chats, and the Sign in button is where that question comes up. The tooltip answers it in user terms without explaining how chats run. The alternative, more inline text, already exists in each row's description and is easy to skip past; the ⓘ puts the answer on the button the question is about.

Difference from the style guide: it prefers tooltips for naming controls rather than explaining. Intended: this is a maintainer-requested explanation, and the inline description stays as the always-visible version.

Linked Issue

N/A (maintainer request).

Visual Proof

Before: the same rows with only the Sign in button (no ⓘ). After, from real runs of this branch on macOS (fresh profile, Chat UI turned on, the Antigravity chat server installed through the UI). Current head, after merging main's new Providers layout (#30850), run on a second Mac:

Settings › Chat › Providers, hovering the ⓘ

providers-tooltip-merged.png

Settings › Accounts › Antigravity › Antigravity chats, hovering the ⓘ

accounts-tooltip-merged.png

Same row, ⓘ reached by keyboard focus (earlier run, before the main merge; this row did not change in it)

accounts-tooltip-focus.png

Testing

  • Existing AntigravityChatSignInRow and AntigravityAccountsSection tests pass.

  • Electron QA on macOS (isolated test copy driven over the DevTools protocol): turned on Chat UI, installed the Antigravity chat server from the Providers row, then checked both rows: the ⓘ sits just left of an enabled Sign in button and shows the tooltip text verbatim on hover and on keyboard focus. Re-run on the current head after merging main, on a second Mac, with the same result. Sign in itself was not clicked; this PR does not change sign-in.

  • I manually tested these changes locally

  • Automated tests added/updated, or explained why not below: copy-only addition next to an existing button; no behavior to pin.

Review

Agent skill upstream boundary

  • Not applicable, or this change copies or mechanically translates no upstream skill-installer source, tests, fixtures, registry entries, path tables, comments, or documentation.

Notes

Renderer-only. Works the same for local and SSH hosts (the row is per host). Merged with main after #30850 (new Providers sign-in layout); the ⓘ sits beside that layout's outline Sign in button, and #30850's test now renders inside the tooltip provider the ⓘ needs.

Checklist

  • This PR is small and focused
  • I explained what changed and why (ELI5, the user-facing before/after, the mechanism, and why over the alternatives)
  • Before/after screenshots or videos attached for UI changes, or N/A with reason
  • Self-reviewed for correctness, security, and performance
  • Cross-platform, SSH/remote, and path/shortcut impact considered (or N/A)
  • pnpm lint, pnpm typecheck, pnpm test, and pnpm build pass (or CI will cover; local preferred)

…ity-signin-info-tooltip

# Conflicts:
#	src/renderer/src/components/settings/AntigravityProviderSignInArea.tsx
@brennanb2025
brennanb2025 marked this pull request as ready for review October 20, 2026 03:34
@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

📝 Walkthrough

The settings sign-in controls now include an information tooltip that explains Antigravity chat sign-in is separate from agy CLI sign-in. The tooltip text is available in English, Spanish, French, Japanese, Korean, and Simplified Chinese. The test wraps the sign-in area in a TooltipProvider.

Priority: ⬇️ Low

Merge Risk: 🔵 Low · up to a15dc

The informational control remains visible during a shared sign-in; hide it in both layouts before merging.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and accurately describes the primary change: explaining why Antigravity chat sign-in is separate from the agy CLI login.
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 3 files. (6 skipped: 6 …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The pull request description is complete and matches the repository template. It explains the user impact, changes, rationale, testing, visual proof, scope, and checklist status. The linked issue is m…
Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 3 files. (6 skipped: 6 unsupported.)

Full details: Description check

Explanation

The pull request description is complete and matches the repository template. It explains the user impact, changes, rationale, testing, visual proof, scope, and checklist status. The linked issue is marked N/A because this is a maintainer request, which matches the template’s maintainer exception.

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b0723d66-191a-409e-9e1c-11998b722e77
📥 Commits

Reviewing files that changed from the base of the PR and between c4a6081 and a15dcf1.

📒 Files selected for processing: 9
  • src/renderer/src/components/settings/AntigravityChatSignInRow.test.tsx
  • src/renderer/src/components/settings/AntigravityChatSignInRow.tsx
  • src/renderer/src/components/settings/AntigravityProviderSignInArea.tsx
  • src/renderer/src/i18n/locales/en.json
  • src/renderer/src/i18n/locales/es.json
  • src/renderer/src/i18n/locales/fr.json
  • src/renderer/src/i18n/locales/ja.json
  • src/renderer/src/i18n/locales/ko.json
  • src/renderer/src/i18n/locales/zh.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 2 remain after this review.

Comment thread src/renderer/src/components/settings/AntigravityChatSignInRow.tsx
@brennanb2025
brennanb2025 deleted the brennanb2025/antigravity-signin-info-tooltip branch October 20, 2026 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant