Repository navigation
feat(settings): explain beside Antigravity's sign-in why the agy CLI login doesn't carry over - #30909
brennanb2025 wants to merge 3 commits into
Conversation
…login doesn't carry over
…ity-signin-info-tooltip # Conflicts: # src/renderer/src/components/settings/AntigravityProviderSignInArea.tsx
📝 Walkthrough
Priority: ⬇️ Low Merge Risk: 🔵 Low · up to
|
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Repository UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
b0723d66-191a-409e-9e1c-11998b722e77
📒 Files selected for processing: 9
src/renderer/src/components/settings/AntigravityChatSignInRow.test.tsxsrc/renderer/src/components/settings/AntigravityChatSignInRow.tsxsrc/renderer/src/components/settings/AntigravityProviderSignInArea.tsxsrc/renderer/src/i18n/locales/en.jsonsrc/renderer/src/i18n/locales/es.jsonsrc/renderer/src/i18n/locales/fr.jsonsrc/renderer/src/i18n/locales/ja.jsonsrc/renderer/src/i18n/locales/ko.jsonsrc/renderer/src/i18n/locales/zh.json
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 2 remain after this review.
ELI5
People who already signed in to Antigravity with the
agycommand in their terminal see a "Sign in" button for Antigravity chats and wonder why they have to sign in again. There's now a small info button beside that Sign in button. Hovering it explains: "Antigravity chats have their own sign-in. Signing in to the agy CLI doesn't sign you in here."What Changed
Before: Settings › Chat › Providers (under Antigravity) and Settings › Accounts › Antigravity ("Antigravity chats") showed a Sign in / Change account / Retry sign-in button with nothing to explain why an agy terminal login doesn't count.
After: both places show an ⓘ button just left of that button. Its tooltip says "Antigravity chats have their own sign-in. Signing in to the agy CLI doesn't sign you in here." The ⓘ is hidden while a sign-in is running (the row then shows Copy link and Cancel instead).
Mechanism: one new
AntigravityChatSignInInfocomponent inAntigravityChatSignInRow.tsx(a ghost icon button with a tooltip), placed next to the action button in both sign-in layouts. New copy is translated in all six locales.Why
Users assume their
agyCLI login carries over to chats, and the Sign in button is where that question comes up. The tooltip answers it in user terms without explaining how chats run. The alternative, more inline text, already exists in each row's description and is easy to skip past; the ⓘ puts the answer on the button the question is about.Difference from the style guide: it prefers tooltips for naming controls rather than explaining. Intended: this is a maintainer-requested explanation, and the inline description stays as the always-visible version.
Linked Issue
N/A (maintainer request).
Visual Proof
Before: the same rows with only the Sign in button (no ⓘ). After, from real runs of this branch on macOS (fresh profile, Chat UI turned on, the Antigravity chat server installed through the UI). Current head, after merging main's new Providers layout (#30850), run on a second Mac:
Settings › Chat › Providers, hovering the ⓘ
Settings › Accounts › Antigravity › Antigravity chats, hovering the ⓘ
Same row, ⓘ reached by keyboard focus (earlier run, before the main merge; this row did not change in it)
Testing
Existing
AntigravityChatSignInRowandAntigravityAccountsSectiontests pass.Electron QA on macOS (isolated test copy driven over the DevTools protocol): turned on Chat UI, installed the Antigravity chat server from the Providers row, then checked both rows: the ⓘ sits just left of an enabled Sign in button and shows the tooltip text verbatim on hover and on keyboard focus. Re-run on the current head after merging main, on a second Mac, with the same result. Sign in itself was not clicked; this PR does not change sign-in.
I manually tested these changes locally
Automated tests added/updated, or explained why not below: copy-only addition next to an existing button; no behavior to pin.
Review
Agent skill upstream boundary
Notes
Renderer-only. Works the same for local and SSH hosts (the row is per host). Merged with main after #30850 (new Providers sign-in layout); the ⓘ sits beside that layout's outline Sign in button, and #30850's test now renders inside the tooltip provider the ⓘ needs.
Checklist
N/Awith reasonpnpm lint,pnpm typecheck,pnpm test, andpnpm buildpass (or CI will cover; local preferred)