Skip to content

style: format the files #29042 merged unformatted (fix red main) - #30953

Closed
brennanb2025 wants to merge 1 commit into
mainfrom
brennanb2025/format-wsl-pairing-files
Closed

brennanb2025 wants to merge 1 commit into
mainfrom
brennanb2025/format-wsl-pairing-files

Conversation

@brennanb2025

@brennanb2025 brennanb2025 commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 3 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​41 $\color{#cf222e}{\Huge{\mathbf{−}}}$​15 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​26
Prod 4 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​45 $\color{#cf222e}{\Huge{\mathbf{−}}}$​32 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​13

What broke

Every PR's static check fails on main right now. #29042 ("keep the desktop pairing across host restarts") merged three files that the formatter rejects: wsl-orcad-connection.ts, wsl-orcad-pairing-identity.ts and orcad-managed-tunnel-identity-restart.test.ts. CI runs the formatter check before typecheck and tests, so every PR merged with current main stops there (for example #28457's run 39353802636).

The earlier formatting fixes (#30828, #30918, #30929) landed before #29042, so they don't cover these files.

What changed

  • Formatted the three files.
  • Formatting pushes wsl-orcad-connection.ts past the 300-line file limit, so its two error classes (WslOrcadLaunchDeferredError, WslOrcadConnectionSupersededError) move unchanged to wsl-orcad-connection-errors.ts, and the one-line default transport helper is inlined at its single call site. The three files that import the errors now import them from the new file.

No behavior change. Nothing user-facing.

Testing

  • oxfmt --check and oxlint are clean on the touched files.
  • wsl-orcad-connection.test.ts, wsl-host-service.test.ts and orcad-managed-tunnel-identity-restart.test.ts pass (36 tests).

@coderabbitai

coderabbitai Bot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 5 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 866e144e-9812-43d9-bc4c-165aac06f060
📥 Commits

Reviewing files that changed from the base of the PR and between 907694d and 26a6ebc.

📒 Files selected for processing: 7
  • src/main/managed-server/lifecycle/orcad-managed-tunnel-identity-restart.test.ts
  • src/main/wsl/wsl-host-first-connect.ts
  • src/main/wsl/wsl-host-service.test.ts
  • src/main/wsl/wsl-orcad-connection-errors.ts
  • src/main/wsl/wsl-orcad-connection.test.ts
  • src/main/wsl/wsl-orcad-connection.ts
  • src/main/wsl/wsl-orcad-pairing-identity.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@brennanb2025

Copy link
Copy Markdown
Contributor Author

Closing: #30948 already formatted these files on main.

@brennanb2025
brennanb2025 deleted the brennanb2025/format-wsl-pairing-files branch October 20, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant