Repository navigation
style: format the files #29042 merged unformatted (fix red main) - #30953
Closed
brennanb2025 wants to merge 1 commit into
Closed
brennanb2025 wants to merge 1 commit into
brennanb2025 wants to merge 1 commit into
Conversation
…onnection under its line limit
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 5 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 20, 2026
Contributor
Author
|
Closing: #30948 already formatted these files on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What broke
Every PR's static check fails on main right now. #29042 ("keep the desktop pairing across host restarts") merged three files that the formatter rejects:
wsl-orcad-connection.ts,wsl-orcad-pairing-identity.tsandorcad-managed-tunnel-identity-restart.test.ts. CI runs the formatter check before typecheck and tests, so every PR merged with current main stops there (for example #28457's run 39353802636).The earlier formatting fixes (#30828, #30918, #30929) landed before #29042, so they don't cover these files.
What changed
wsl-orcad-connection.tspast the 300-line file limit, so its two error classes (WslOrcadLaunchDeferredError,WslOrcadConnectionSupersededError) move unchanged towsl-orcad-connection-errors.ts, and the one-line default transport helper is inlined at its single call site. The three files that import the errors now import them from the new file.No behavior change. Nothing user-facing.
Testing
oxfmt --checkandoxlintare clean on the touched files.wsl-orcad-connection.test.ts,wsl-host-service.test.tsandorcad-managed-tunnel-identity-restart.test.tspass (36 tests).