Repository navigation
fix(orcad): orca open-url on a server you started asks for a paired desktop, not an SSH setting - #31120
Merged
Conversation
…esktop again, not an SSH setting Every orcad turned on the SSH host browser bridge, so since open-url began going through it (#30849) a user-started serve with no desktop refused with SSH-settings advice. Only a client's managed launch enables the bridge now; a started server answers browser_host_unavailable (#30782).
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 2 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
You start
orca serveyourself and pair a desktop with it. If you runorca open-urlbefore any desktop is showing that server's pages, the command fails, as it should. But the error it gives tells you to go change an SSH-host setting, which this server doesn't have. This PR brings back the error that tells you what to actually do: open a browser tab for this server on a paired desktop.What Changed
orca open-urlwith no desktop showing its pages failed withdesktop_browser_bridge_unavailable. The message was "open this host's SSH settings, turn on 'Allow this host's orca CLI to control Orca'".browser_host_unavailable: "No paired Orca desktop is hosting browser pages for this server. On a desktop paired with it, open a browser tab in one of this server's workspaces, then retry." This is the behaviour fix(orcad): orca open-url opens the page on the paired desktop #30782 designed for this path.orcad-lifecycle.ts), including ones a user started.browser.openUrlalso goes through the bridge, so with no desktop attached the bridge's refusal answered first.ORCA_ORCAD_MANAGED_ACTIVATION_ROOT, which only a managed launch sets.open-url. That change is correct on managed SSH hosts; this PR only narrows where the bridge is switched on.Why
open-urlinside the bridge route. That would leave every other browser command on a user-started server with the same wrong advice.Linked Issue
Found during the terminal-layout headless work (track H). No issue.
Visual Proof
N/A for UI. This is CLI output. With no desktop hosting pages,
orca open-urlprints:Before:
After:
Testing
I manually tested these changes locally
Automated tests added/updated, or explained why not below
Unit:
orcad-lifecycle-host.test.tschecks that the bridge is on for a managed launch and off for a user-started server, and off after stop. The user-started case fails on base and passes on head.e2e:
tests/e2e/orcad-serve-open-url-on-desktop.spec.ts, which fix(orcad): orca open-url opens the page on the paired desktop #30782 added and which expectsbrowser_host_unavailable. Run on macOS, hidden, withORCA_E2E_ORCAD_SERVE=1:desktop_browser_bridge_unavailable.pnpm tc,check:code-quality:changed, type-aware oxlint, the layout-writer ratchet, and the bridge and orcad unit suites pass.Review
Agent skill upstream boundary
Notes
Checklist
N/Awith reasonpnpm lint,pnpm typecheck,pnpm test, andpnpm buildpass (or CI will cover; local preferred)