Repository navigation
test: format pty-connection-split-spawn.spec.ts so main's formatting check passes - #31379
brennanb2025 wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to
|
|
Main’s formatting check rejected this test after #30442, causing unrelated PRs to fail static analysis. This PR reformats that one test without changing its behavior. Review found that the complete repair already landed in #31378 at
For Brennan’s review: the only decision is disposition of this duplicate of #31378. There are no UI differences or product choices in the diff. This review did not merge or close either PR. |
|
Closing: #31378 landed the same formatting fix. |
ELI5
Main's formatting check fails on one test file, so every open PR's static-analysis job goes red on a file it never touched. This runs the formatter on that file.
What Changed
src/renderer/src/components/terminal-pane/pty-connection-split-spawn.spec.tscame in unformatted with #30442. This PR is onlyoxfmton that file: whitespace and line wrapping, no test changes.Why
Static analysis on PRs checks the merge with main, so #30442's unformatted file fails every PR (seen on #31315). The same kind of fix as #31294.
Linked Issue
N/A, main CI fix.
Visual Proof
N/A: test-file formatting only.
Testing
npx oxfmt --writeon the file with the repo config; CI's static analysis is the check.Notes
Author: Brennan Benson (@BrennanKB5)