Skip to content

test: format pty-connection-split-spawn.spec.ts so main's formatting check passes - #31379

Closed
brennanb2025 wants to merge 1 commit into
mainfrom
brennanb2025/main-format-pty-split-spawn
Closed

brennanb2025 wants to merge 1 commit into
mainfrom
brennanb2025/main-format-pty-split-spawn

Conversation

@brennanb2025

@brennanb2025 brennanb2025 commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 1 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​106 $\color{#cf222e}{\Huge{\mathbf{−}}}$​105 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​1
Prod 0 0 0 0

ELI5

Main's formatting check fails on one test file, so every open PR's static-analysis job goes red on a file it never touched. This runs the formatter on that file.

What Changed

src/renderer/src/components/terminal-pane/pty-connection-split-spawn.spec.ts came in unformatted with #30442. This PR is only oxfmt on that file: whitespace and line wrapping, no test changes.

Why

Static analysis on PRs checks the merge with main, so #30442's unformatted file fails every PR (seen on #31315). The same kind of fix as #31294.

Linked Issue

N/A, main CI fix.

Visual Proof

N/A: test-file formatting only.

Testing

  • npx oxfmt --write on the file with the repo config; CI's static analysis is the check.

Notes

Author: Brennan Benson (@BrennanKB5)

@coderabbitai

coderabbitai Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 44188854-3ee6-44f7-b376-91b6cbc2af6d
📥 Commits

Reviewing files that changed from the base of the PR and between f7c0740 and 3c5db7f.

📒 Files selected for processing: 1
  • src/renderer/src/components/terminal-pane/pty-connection-split-spawn.spec.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review.

📝 Walkthrough

The parameterized startup and fallback test was reformatted. Its scenarios, control flow, assertions, and observable behavior remain unchanged.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 3c5db

This PR only reformats an existing test and presents no identified merge-blocking behavior change.

Pre-merge checks: Passed 3 · Failed 2

Failed Failed checks: 2 warnings

Check name Status Explanation Resolution
Description check Warning The description clearly explains the formatting-only change, reason, scope, visual-proof exception, and testing. However, it does not provide the required linked issue and omits several template secti… Add an actual issue link in the Linked Issue section, unless the author is a repository maintainer covered by the stated exception. Complete or explicitly mark the Review, Agent skill upstream boundary, Notes, and Checklist sections as appl…
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 3 passed
Check name Status Explanation
Title check Passed The title clearly identifies the formatting change and its purpose: making the main branch formatting check pass for the specified test file.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description clearly explains the formatting-only change, reason, scope, visual-proof exception, and testing. However, it does not provide the required linked issue and omits several template sections and checklist confirmations.

Resolution

Add an actual issue link in the Linked Issue section, unless the author is a repository maintainer covered by the stated exception. Complete or explicitly mark the Review, Agent skill upstream boundary, Notes, and Checklist sections as applicable.

✨ Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@brennanb2025

Copy link
Copy Markdown
Contributor Author

Main’s formatting check rejected this test after #30442, causing unrelated PRs to fail static analysis. This PR reformats that one test without changing its behavior.

Review found that the complete repair already landed in #31378 at a763c1d8b73973ca0751e647ea34c586e7b26b07. The file on current main and this PR’s head is byte-for-byte identical, so this PR now adds no change over main.

  • Verified head: 3c5db7f4fb9408866428f0ec48c6f6e64d5fd2ce. One independent adversarial review found no code defects; all 4,249 TypeScript tokens and comments are identical before and after formatting, and the parsed syntax is unchanged.
  • Exact-head CI passed, including formatting, static analysis, all five unit-test shards, and relay integration.
  • Scope: one test file, zero production changes; QA classification is tests-only (qa=none). No app run or screenshots are needed.
  • No fixes were made during review. PR disposition is deferred to its owner. Three light-path criteria pass; the non-repeat criterion cannot be certified against current main because the identical repair has landed. This is superseded, not a completed readiness loop; no completion marker is issued.

For Brennan’s review: the only decision is disposition of this duplicate of #31378. There are no UI differences or product choices in the diff. This review did not merge or close either PR.

@brennanb2025

Copy link
Copy Markdown
Contributor Author

Closing: #31378 landed the same formatting fix.

@brennanb2025
brennanb2025 deleted the brennanb2025/main-format-pty-split-spawn branch October 21, 2026 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant