[brennanb2025]

	Files	Added	Deleted	Net
Test	1	$\color{#1a7f37}{\Huge{\mathbf{+}}}$​2	$\color{#cf222e}{\Huge{\mathbf{−}}}$​1	$\color{#1a7f37}{\Huge{\mathbf{+}}}$​1
Prod	4	$\color{#1a7f37}{\Huge{\mathbf{+}}}$​147	$\color{#cf222e}{\Huge{\mathbf{−}}}$​141	$\color{#1a7f37}{\Huge{\mathbf{+}}}$​6

ELI5

Main's lint is red: one shared file about chat questions grew past the 300-code-line limit. This moves one self-contained part of it (the code that turns a question answer into keystrokes for the agent's terminal) into its own file. Nothing behaves differently.

What Changed

• src/shared/native-chat-ask.ts had 310 code lines against the 300 limit for .ts files (max-lines in .oxlintrc.json, blank lines and comments skipped). Recent main commits fix(agent-status): questions over 16 KB show their card with every option #31632 and fix(native-chat): Codex async questions show an answer card on desktop and phone #31652 together pushed it over, so the static lint job fails on every PR based on current main (for example build: generate the RPC params catalog and bundled skill guides at build time #30644: https://github.com/stablyai/orca/actions/runs/39697950184/job/119559979235).
• New src/shared/native-chat-ask-keystrokes.ts holds the PTY keystroke builders, moved unchanged: AskAnswerKeyGroup, the selector key constants, buildAskAnswerKeys (Claude's arrow-navigate selector) and buildCodexAskAnswerKeys (Codex's request_user_input overlay).
• answerLabels stays in native-chat-ask.ts (it also backs formatAskAnswer) and is now exported so the keystroke module can use it.
• Importers updated: native-chat-interactive-prompt.ts (which re-exports these for the renderer, so other renderer files are unchanged), mobile's use-mobile-native-chat-answer-send.ts, and mobile-prompt-controller.test.ts.
• native-chat-ask.ts is now about 225 code lines; the new file about 87.

User-facing change: none. Developer-facing change: main's lint goes green again for this file.

Why

The keystroke builders are the one part of the file with a single job of their own (driving each agent's terminal question selector) and only one dependency back (answerLabels), so they split out cleanly with a pure move. No max-lines disable.

Plan (light path): move the keystroke builders into a sibling module, update imports, run the covering tests, let CI be the lint and typecheck gate.

• Production lines: pure move, about 90 lines moved, 5 production files touched (≤ 150 lines, ≤ 5 files).
• No saved data, wire or RPC payloads, lifecycle, processes, build or packaging, or cross-version behavior: code is moved verbatim.
• Not a repeat fix in one mechanism: it is a file-size fix.

ClientHostedBrowserPagePane.tsx also fails max-lines on main; that is fixed separately in #31729 and not touched here.

Linked Issue

N/A (main's lint is red; no issue).

Visual Proof

N/A: code move only, no UI or behavior change.

Testing

• src/shared/native-chat-ask.test.ts, src/shared/native-chat-ask-fifo.test.ts, src/renderer/src/components/native-chat/native-chat-interactive-prompt.test.ts (covers both keystroke builders): 53 passed locally.

• Mobile tests touching the moved imports run in CI.

• I manually tested these changes locally

• Automated tests added/updated, or explained why not below (existing tests cover the moved code; no new behavior)

AI Disclosure

Review

Agent skill upstream boundary

• Not applicable, or this change copies or mechanically translates no upstream skill-installer source, tests, fixtures, registry entries, path tables, comments, or documentation.

Notes

Pure code move; no security, platform, SSH, mobile behavior, compatibility or performance impact.

Checklist

• This PR is small and focused
• I explained what changed and why (ELI5, the user-facing before/after, the mechanism, and why over the alternatives)
• Before/after screenshots or videos attached for UI changes, or N/A with reason
• Self-reviewed for correctness, security, and performance
• Cross-platform, SSH/remote, and path/shortcut impact considered (or N/A)
• pnpm lint, pnpm typecheck, pnpm test, and pnpm build pass (or CI will cover; local preferred)

[coderabbitai]

📝 Walkthrough

The Claude and Codex keystroke builders moved from native-chat-ask to native-chat-ask-keystrokes. The new module exports AskAnswerKeyGroup and both builders. answerLabels is now exported from native-chat-ask. Mobile and renderer imports were updated; the test import was split into separate type and value imports.

Priority: ⬇️ Low

Merge Risk: 🔵 Low · up to 04b5b

The keystroke move leaves one test unable to import its builder. Update that import before relying on the test; the identified risk is localized.

Pre-merge checks: 5

Check name	Status	Explanation
Title check		The title clearly and concisely describes the main change: moving code from native-chat-ask.ts to resolve the max-lines lint failure.
Description check		The description is detailed and covers the change, rationale, testing, visual impact, scope, and checklist. It explicitly documents that no linked issue exists and that full local validation commands …
Docstring Coverage		Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 5 files.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description is detailed and covers the change, rationale, testing, visual impact, scope, and checklist. It explicitly documents that no linked issue exists and that full local validation commands were not run, so CI coverage is expected.

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

---

ℹ️ Review info

⚙️ Run configuration

• Configuration used: Repository UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 12e728eb-79e6-4407-8e81-0bc9d909055a

📥 Commits

Reviewing files that changed from the base of the PR and between b0fcdb4 and 04b5b56.

📒 Files selected for processing: 5

• mobile/src/session/mobile-prompt-controller.test.ts
• mobile/src/session/use-mobile-native-chat-answer-send.ts
• src/renderer/src/components/native-chat/native-chat-interactive-prompt.ts
• src/shared/native-chat-ask-keystrokes.ts
• src/shared/native-chat-ask.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review.

[coderabbitai]

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

🔎 Supported by static analysis

🏁 Script executed:

#!/bin/bash
# Find imports of the moved symbols that still point at native-chat-ask (not the keystrokes module).
rg -nU --type=ts -C2 "(buildAskAnswerKeys|buildCodexAskAnswerKeys|AskAnswerKeyGroup)" \
  -g '!src/shared/native-chat-ask-keystrokes.ts' | rg -n "native-chat-ask['\"]|native-chat-ask-keystrokes"

# List every importer of the old module for manual review.
rg -n --type=ts "from '.*native-chat-ask'" -g '!node_modules'

Repository: stablyai/orca

Length of output: 4662

---

🏁 Script executed:

#!/bin/bash
set -eu
printf '%s\n' '--- stale importer ---'
nl -ba tests/e2e/native-chat-ssh-delivery.unit.test.ts | sed -n '1,35p'
printf '%s\n' '--- old module moved-symbol references/exports ---'
rg -n -C2 --type=ts 'buildAskAnswerKeys|buildCodexAskAnswerKeys|AskAnswerKeyGroup|^export ' src/shared/native-chat-ask.ts || true
printf '%s\n' '--- new module ---'
nl -ba src/shared/native-chat-ask-keystrokes.ts | sed -n '1,140p'

Repository: stablyai/orca

Length of output: 11485

---

Update the remaining stale import.

tests/e2e/native-chat-ssh-delivery.unit.test.ts imports buildAskAnswerKeys from the old module. Import it from native-chat-ask-keystrokes instead.

Suggested fix

-import { buildAskAnswerKeys } from '../../src/shared/native-chat-ask'
+import { buildAskAnswerKeys } from '../../src/shared/native-chat-ask-keystrokes'

[brennanb2025]

Closing as a duplicate: #31729 already moves the same code out of native-chat-ask.ts (and fixes the browser pane), so this PR's whole change is held there.