You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
refactor: group shared native chat composer input - #34328
Group seven shared native-chat input modules under src/shared/native-chat/input/. Import their concrete owners throughout desktop and mobile, remove five forwarding exports and the renderer launch-draft forwarding file, and retarget the two existing test timing keys. Function bodies, non-module literals, and timing values are unchanged.
Validated with 158 tests across 10 suites, desktop and mobile typechecks, formatting, changed-code quality, and a complete decoded stale-owner scan. Independent review and hosted CI remain required before merge.
Integration note: #31180 edits the picker owner; its command-availability filtering and skill-safety changes must be preserved under the moved path when that work is integrated.
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review.
Walkthrough
The change aligns native-chat input imports with the shared/native-chat/input module paths across mobile, renderer, main-process, and shared code. The renderer composer-state module no longer re-exports slash-command, send-classification, and picker APIs; callers import them from dedicated modules. The mirrorability helper is imported from shared input code, and its renderer re-export module is removed. CI timing keys use the updated test paths.
Priority: Low
Merge Risk: Minimal · up to e84df
The module migration appears mergeable after normal checks; no broken import was identified.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Description check
The description summarizes the refactor and validation, but it omits most required template sections, including explicit ELI5, Why, Linked Issue, Visual Proof, Testing details, Review, Notes, and Chec…
Complete the required template sections. Add an actual linked issue, state N/A with a reason for Visual Proof, document testing steps and platforms, complete the applicable checklists, and explain the rationale and compatibility considera…
Passed checks: 4 passed
Check name
Status
Explanation
Title check
The title clearly and concisely describes the main change: grouping shared native-chat composer input modules.
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 31 files. (1 skipped: 1 unsupported.)
Full details: Description check
Explanation
The description summarizes the refactor and validation, but it omits most required template sections, including explicit ELI5, Why, Linked Issue, Visual Proof, Testing details, Review, Notes, and Checklist content.
Resolution
Complete the required template sections. Add an actual linked issue, state N/A with a reason for Visual Proof, document testing steps and platforms, complete the applicable checklists, and explain the rationale and compatibility considerations.
Finishing Touches
📝 Generate docstrings
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Group seven shared native-chat input modules under
src/shared/native-chat/input/. Import their concrete owners throughout desktop and mobile, remove five forwarding exports and the renderer launch-draft forwarding file, and retarget the two existing test timing keys. Function bodies, non-module literals, and timing values are unchanged.Validated with 158 tests across 10 suites, desktop and mobile typechecks, formatting, changed-code quality, and a complete decoded stale-owner scan. Independent review and hosted CI remain required before merge.
Integration note: #31180 edits the picker owner; its command-availability filtering and skill-safety changes must be preserved under the moved path when that work is integrated.