Skip to content

refactor: group shared native chat composer input - #34328

Merged
nwparker merged 2 commits into
mainfrom
nwparker/refactor-shared-chat-input-pr123
Oct 27, 2026
Merged

nwparker merged 2 commits into
mainfrom
nwparker/refactor-shared-chat-input-pr123

Conversation

@nwparker

@nwparker nwparker commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor
Files Added Deleted Net
Test 10 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​18 $\color{#cf222e}{\Huge{\mathbf{−}}}$​19 $\color{#cf222e}{\Huge{\mathbf{−}}}$​1
Prod 27 $\color{#1a7f37}{\Huge{\mathbf{+}}}$​56 $\color{#cf222e}{\Huge{\mathbf{−}}}$​76 $\color{#cf222e}{\Huge{\mathbf{−}}}$​20

Group seven shared native-chat input modules under src/shared/native-chat/input/. Import their concrete owners throughout desktop and mobile, remove five forwarding exports and the renderer launch-draft forwarding file, and retarget the two existing test timing keys. Function bodies, non-module literals, and timing values are unchanged.

Validated with 158 tests across 10 suites, desktop and mobile typechecks, formatting, changed-code quality, and a complete decoded stale-owner scan. Independent review and hosted CI remain required before merge.

Integration note: #31180 edits the picker owner; its command-availability filtering and skill-safety changes must be preserved under the moved path when that work is integrated.

@coderabbitai

coderabbitai Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 66e7bde6-19aa-403c-9805-5a3a4b7565ec
Commits

Reviewing files that changed from the base of the PR and between 755bbfa and e84df4f.

Files selected for processing: 37
  • config/scripts/ci-shard-timings.json
  • mobile/src/session/native-chat/composer/MobileNativeChatComposerMenu.tsx
  • mobile/src/session/native-chat/composer/mobile-native-chat-composer-menu.ts
  • mobile/src/session/native-chat/mobile-native-chat-send-classification.ts
  • mobile/src/session/use-mobile-native-chat-message-send.ts
  • src/main/window/native-chat-paste-files.ts
  • src/renderer/src/components/native-chat/NativeChatAutocompleteMenus.test.tsx
  • src/renderer/src/components/native-chat/NativeChatAutocompleteMenus.tsx
  • src/renderer/src/components/native-chat/NativeChatComposer.resume-command.test.tsx
  • src/renderer/src/components/native-chat/NativeChatComposerField.tsx
  • src/renderer/src/components/native-chat/native-chat-composer-state.test.ts
  • src/renderer/src/components/native-chat/native-chat-composer-state.ts
  • src/renderer/src/components/native-chat/native-chat-image-paste.ts
  • src/renderer/src/components/native-chat/use-native-chat-composer-catalog.test.tsx
  • src/renderer/src/components/native-chat/use-native-chat-composer-catalog.ts
  • src/renderer/src/components/native-chat/use-native-chat-composer-keydown.test.tsx
  • src/renderer/src/components/native-chat/use-native-chat-composer-keydown.ts
  • src/renderer/src/components/native-chat/use-native-chat-composer-submit.test.tsx
  • src/renderer/src/components/native-chat/use-native-chat-composer-submit.ts
  • src/renderer/src/components/native-chat/use-native-chat-picker-command-dispatch.ts
  • src/renderer/src/components/native-chat/use-native-chat-picker-state.ts
  • src/renderer/src/components/native-chat/use-native-chat-pty-composer-send.test.tsx
  • src/renderer/src/components/native-chat/use-native-chat-pty-composer-send.ts
  • src/renderer/src/components/native-chat/use-native-chat-resume-command.ts
  • src/renderer/src/lib/agent-launch-prompt-delivery.ts
  • src/renderer/src/lib/native-chat-launch-draft-mirrorability.test.ts
  • src/renderer/src/lib/native-chat-launch-draft-mirrorability.ts
  • src/shared/native-chat-agent-profiles.ts
  • src/shared/native-chat-reported-skill.ts
  • src/shared/native-chat/input/native-chat-launch-draft-mirrorability.ts
  • src/shared/native-chat/input/native-chat-paste-folder.ts
  • src/shared/native-chat/input/native-chat-picker-items.ts
  • src/shared/native-chat/input/native-chat-picker-triggers.ts
  • src/shared/native-chat/input/native-chat-slash-commands.omp.test.ts
  • src/shared/native-chat/input/native-chat-slash-commands.test.ts
  • src/shared/native-chat/input/native-chat-slash-commands.ts
  • src/shared/structured-agent-session-composer.ts
Files with no reviewable changes: 1
  • src/renderer/src/lib/native-chat-launch-draft-mirrorability.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review.

Walkthrough

The change aligns native-chat input imports with the shared/native-chat/input module paths across mobile, renderer, main-process, and shared code. The renderer composer-state module no longer re-exports slash-command, send-classification, and picker APIs; callers import them from dedicated modules. The mirrorability helper is imported from shared input code, and its renderer re-export module is removed. CI timing keys use the updated test paths.

Priority: Low

Merge Risk: Minimal · up to e84df

The module migration appears mergeable after normal checks; no broken import was identified.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning The description summarizes the refactor and validation, but it omits most required template sections, including explicit ELI5, Why, Linked Issue, Visual Proof, Testing details, Review, Notes, and Chec… Complete the required template sections. Add an actual linked issue, state N/A with a reason for Visual Proof, document testing steps and platforms, complete the applicable checklists, and explain the rationale and compatibility considera…
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: grouping shared native-chat composer input modules.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 31 files. (1 skipped: 1 unsupported.)

Full details: Description check

Explanation

The description summarizes the refactor and validation, but it omits most required template sections, including explicit ELI5, Why, Linked Issue, Visual Proof, Testing details, Review, Notes, and Checklist content.

Resolution

Complete the required template sections. Add an actual linked issue, state N/A with a reason for Visual Proof, document testing steps and platforms, complete the applicable checklists, and explain the rationale and compatibility considerations.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nwparker
nwparker merged commit c8823b4 into main Oct 27, 2026
44 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant