Repository navigation
fix(main): drop stray tr.json keys and split runtime-file-read-client under max-lines - #34929
Conversation
#31180 removed components.native-chat.queuedMessages.cancelEditing, .pasteOrDropImages and .saveNeedsContent from en.json; tr.json, added since, still carried them, so the locale catalog check failed on main. They are the only stray keys in any locale.
Move the remote chunked-download helpers into runtime-remote-file-download.ts so runtime-file-read-client.ts is back under the 300-line lint cap. No behaviour change.
nwparker
changed the title
|
No actionable comments were generated in the recent review.
 |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Title check The title clearly identifies both primary changes: removing stray Turkish locale keys and splitting runtime-file-read-client to satisfy the max-lines limit. Description check The description follows the repository template and explains the changes, reasons, testing, visual proof, scope, and checklist. It does not report results for pnpm lint, pnpm typecheck, pnpm test, or … Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Description check
-
Explanation
The description follows the repository template and explains the changes, reasons, testing, visual proof, scope, and checklist. It does not report results for pnpm lint, pnpm typecheck, pnpm test, or pnpm build, but this is a non-critical omission because CI coverage is noted.
-
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 3 functions across 2 files. (1 skipped: 1 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
ELI5
Main's locale catalog check (
verify:localization-catalogs) fails becausetr.jsonstill has three strings that the English catalog dropped. This PR removes those three strings, so the check passes again.What Changed
From
src/renderer/src/i18n/locales/tr.jsononly, this removes:components.native-chat.queuedMessages.cancelEditingcomponents.native-chat.queuedMessages.pasteOrDropImagescomponents.native-chat.queuedMessages.saveNeedsContent#31180 removed them from
en.json, but the Turkish catalog still carried them. I compared every locale againsten.json(plural suffixes ignored): these three are the only stray keys in any locale. The file was rewritten through a parse round-trip that reproduces it byte-for-byte, so the diff touches only those three entries.Why
The catalog check treats any key missing from
en.jsonas an error, so main's CI fails until these are gone. Nothing references them anymore.This PR also splits
src/renderer/src/runtime/runtime-file-read-client.ts(304 lines) back under the 300-line lint cap, which also fails main. The remote chunked-download helpers move unchanged into a new sibling file,runtime-remote-file-download.ts, and the exports stay the same. The two fixes land together because each one's CI fails on the other's breakage. This replaces #34930.Linked Issue
N/A (maintainer, main CI fix).
Visual Proof
N/A: drops unused translation strings; no UI change.
Testing
All five localization checks pass on this branch:
verify:localization-catalogsverify:localization-catalogverify:localization-runtime-catalogverify:localization-extractionverify:localization-coverageNo test changes are needed; the checks are the test.
Review
Agent skill upstream boundary
Notes
Turkish locale data only. No cross-platform, SSH or mobile impact.
Checklist
N/Awith reasonpnpm lint,pnpm typecheck,pnpm test, andpnpm buildpass (or CI will cover; local preferred)