Change slurmctld and slurmd spool defaults#206
Merged
Conversation
Previous default didn't clearly identify data as controller vs slurmd.
openhpc_slurmd_spool_dir was not used in slurm.conf
elelaysh
force-pushed
the
feat/change-defaults
branch
from
f5f602a to
ef05e60
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the default spool directories for slurmctld and slurmd. The change for slurmctld's StateSaveLocation to /var/spool/slurmctld is a good improvement for clarity. For slurmd, the SlurmdSpoolDir is now removed from the default configuration to rely on Slurm's own default. However, the implementation hardcodes the directory path in one of the tasks, which removes the ability for users to override this setting. I've provided a suggestion to fix this while keeping the new default behavior.
openhpc_default_config, overriden by openhpc_config
sjpb
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/var/spool/slurmctldthis has no impact on existing deployments because it was already defined in ansible-slurm-appliance
/var/spool/slurmd(note the extra d)
this has an impact but as it reside on the root disk, it will disappear on upgrades