Remove default Preemption configuration#212
Conversation
We should let sites decide what preemption they want and set additional settings like PreemptMode, PreemptExemptTime.
elelaysh
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the default Slurm preemption configuration (PreemptType and PreemptMode) from the Ansible role's defaults, with the goal of making the role less opinionated and allowing sites to configure preemption as needed. My review includes one suggestion to also remove a related configuration parameter for consistency and to simplify the default configuration.
I am having trouble creating individual review comments. Click here to see my feedback.
defaults/main.yml (29-30)
To be consistent with removing opinionated preemption settings, consider also removing PriorityWeightPartition: 1000 from line 28. This setting is only effective when PriorityType=priority/multifactor is configured, which is not the default in Slurm or this role. Removing it would further simplify the default configuration and align with the goal of this PR.
1 participant
We should let sites decide what preemption they want and set additional settings like PreemptMode, PreemptExemptTime.