Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces Sui blockchain support to the @stakekit/signers package, enabling wallet derivation and transaction signing for the Sui network. It also updates dependencies and refines wallet derivation path management.
Key changes:
- Implements Sui signer functionality with Ed25519 keypair support
- Integrates Sui into the wallet derivation path system across multiple wallet types
- Updates package dependencies including TypeScript, Node types, and the addition of
@mysten/sui
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/sui.ts | New module implementing Sui signer classes and wallet getter function |
| src/get-signing-wallet.ts | Adds Sui signing wallet function and registers it in the network getters map |
| src/ethereum/nonce-manager.ts | Adds type assertion for provider field to satisfy type requirements |
| src/constants.ts | Adds Sui derivation paths and integrates Sui support into wallet configurations |
| package.json | Bumps version to 0.1.0, adds Sui dependency, and updates TypeScript and other dependencies |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
package.json
Outdated
| "@solana/web3.js": "1.52.0", | ||
| "@stakekit/common": "^0.0.56", | ||
| "@stakekit/common": "^0.0.58", | ||
| "@stakekit/signers": "link:", |
There was a problem hiding this comment.
The dependency '@stakekit/signers' appears to be a self-reference with 'link:' protocol. This is likely a development artifact and should be removed before publishing, as packages should not depend on themselves.
Suggested change
| "@stakekit/signers": "link:", |
Philippoes
approved these changes
Oct 22, 2025
0xcacti
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
This pull request introduces Sui blockchain support to the
@stakekit/signerspackage, enabling Sui wallet derivation and transaction signing. It also updates several dependencies and improves derivation path management for multiple wallets.Sui blockchain integration:
src/sui.tsmodule implementingSuiSignerandSuiKeypairSignerfor Sui key derivation and transaction signing.get-signing-wallet.ts, including a new getter and wiring for the Sui network. [1] [2] [3]Derivation path enhancements:
suiPath) and included Sui inWalletDomain,steakwalletDerivationPaths, andphantomDerivationPathsto support Sui in various wallet types. UpdatedwalletDerivationPathsto use the new structure. [1] [2] [3] [4]Dependency and configuration updates:
@mysten/suiand@types/bech32as dependencies, updated@stakekit/common, and bumped TypeScript and Node.js type definitions. Set"type": "commonjs"inpackage.json. [1] [2] [3] [4]Other improvements:
providerinNonceManagerto ensure correct typing.These changes collectively enable Sui blockchain support, improve wallet compatibility, and keep dependencies up to date.