Skip to content

feat: dedicated collapsible image section in edit-node modal #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rassl merged 1 commit into from
Jun 14, 2026
Merged

feat: dedicated collapsible image section in edit-node modal #339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions src/components/layout/node-preview-panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -866,13 +866,24 @@ export function NodePreviewPanel({ node, onBack, schemas }: NodePreviewPanelProp
}
}

// Reset local state when an external node selection replaces the prop
// Full reset (currentNode + history + scroll) only when a genuinely different
// node is selected.
useEffect(() => {
setCurrentNode(node)
setHistory([])
scrollContentRef.current?.parentElement?.scrollTo({ top: 0, behavior: 'instant' })
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [node.ref_id])

// Pick up in-place edits to the *currently displayed* node (same ref_id, new
// object) — e.g. an image upload/removal that re-sets selectedNode — so the
// panel refreshes without a full page reload. The ref_id guard avoids
// clobbering a peer the user has navigated to, and leaves history/scroll
// untouched.
useEffect(() => {
setCurrentNode((prev) => (prev.ref_id === node.ref_id ? node : prev))
}, [node])

function handleNavigate(peer: GraphNode) {
setHistory((prev) => [...prev, currentNode])
setCurrentNode(peer)
Expand Down Expand Up @@ -1313,7 +1324,10 @@ export function NodePreviewPanel({ node, onBack, schemas }: NodePreviewPanelProp

{/* Edit node */}
{isAdmin && (
<DropdownMenuItem onClick={() => openEdit(fullNode ?? currentNode)}>
// Seed the modal from the panel's live, in-sync node (currentNode),
// not the separately-fetched fullNode — so reopening after an edit
// always reflects the latest values (one source of truth).
<DropdownMenuItem onClick={() => openEdit(currentNode)}>
<Pencil className="h-3.5 w-3.5 mr-1.5" />
Edit node
</DropdownMenuItem>
Expand Down
Loading
Loading