[Jamie] Fix RecursionCard: ScoreBadge hardcoded loading/error, displayLatest fallback, canExpand fallback - #5136
Open
pitoi wants to merge 2 commits into
Open
[Jamie] Fix RecursionCard: ScoreBadge hardcoded loading/error, displayLatest fallback, canExpand fallback#5136pitoi wants to merge 2 commits into
pitoi wants to merge 2 commits into
Conversation
…yLatest fallback, canExpand fallback
Fixes 22 failing unit tests in `RecursionBox.test.tsx`. Three bugs in the deferred-fetch refactor:
1. `ScoreBadge` is called with hardcoded `isLoading={false}` / `error={null}` — making `score-loading` and `score-error` unreachable.
2. `displayLatest` uses `summaryLatest` unconditionally while collapsed, ignoring hook data — cards show "no runs yet" when `entry.latestRun` isn't set.
3. `canExpand` ignores `rawAttempts.length` while collapsed — expand toggle never appears when `fixChainDepth`/`latestRun` aren't set but hook data is available.
…ist hook to pass correct arguments and stabilize fetch calls in tests
|
Test environment is now live. View it at: https://hive-preview-7.sphinx.chat Database expires at: Aug 23, 2026, 7:50 AM UTC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 22 failing unit tests in
RecursionBox.test.tsx. Three bugs in the deferred-fetch refactor:ScoreBadgeis called with hardcodedisLoading={false}/error={null}— makingscore-loadingandscore-errorunreachable.displayLatestusessummaryLatestunconditionally while collapsed, ignoring hook data — cards show "no runs yet" whenentry.latestRunisn't set.canExpandignoresrawAttempts.lengthwhile collapsed — expand toggle never appears whenfixChainDepth/latestRunaren't set but hook data is available.