[Jamie] Graph Explorer: auto re-run search on node-type filter change - #5181
Open
fayekelmith wants to merge 4 commits into
Open
[Jamie] Graph Explorer: auto re-run search on node-type filter change#5181fayekelmith wants to merge 4 commits into
fayekelmith wants to merge 4 commits into
Conversation
fayekelmith
force-pushed
the
swarm/swarm-change-22b70e9e
branch
2 times, most recently
from
August 27, 2026 23:36
160ab63 to
7027565
Compare
## Problem In Graph Explorer's search panel, changing the node-type filter (or the query text) does not automatically re-run the search — the user has to manually click "Search" again to see filtered results, even though a query is already active. ## Fix Make the node-type filter and query input behave like live search: - Changing `selectedTypes` (checkbox toggle or "clear") while a non-empty query exists auto re-runs the search. - Typing in the query box debounces (~300ms) before auto-firing, to avoid a request per keystroke. - Empty query never triggers an automatic fetch. - In-flight requests are guarded against out-of-order responses so a slow older request can't overwrite a newer result set. - Manual "Search" button and Enter-key trigger remain as an explicit, immediate option. ## Source Confirmed via code read of `src/components/graph-explorer/GraphExplorer.tsx`: `toggleType`/`onClear` only call `setSelectedTypes`; `runSearch` is only invoked by the Search button's `onClick` and the Enter-key handler — no effect currently watches `selectedTypes` or `searchQuery`.
fayekelmith
force-pushed
the
swarm/swarm-change-22b70e9e
branch
from
August 28, 2026 22:50
5438aa8 to
d7a6e1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In Graph Explorer's search panel, changing the node-type filter (or the query text) does not automatically re-run the search — the user has to manually click "Search" again to see filtered results, even though a query is already active.
Fix
Make the node-type filter and query input behave like live search:
selectedTypes(checkbox toggle or "clear") while a non-empty query exists auto re-runs the search.Source
Confirmed via code read of
src/components/graph-explorer/GraphExplorer.tsx:toggleType/onClearonly callsetSelectedTypes;runSearchis only invoked by the Search button'sonClickand the Enter-key handler — no effect currently watchesselectedTypesorsearchQuery.