Build LiveNowPanel UI and harden deep-link navigation for cross-scope click-to-focus - #5199
Open
fayekelmith wants to merge 4 commits into
Conversation
…ation for cross-scope click-to-focus
…arden-deeplink-navigation-1787952520
…arden-deeplink-navigation-1787952520
…arden-deeplink-navigation-1787952520
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Generated with Hive.
OrgCanvasBackground(no new fetch/poll). Renders nothing at all when there's nothing active (zero chrome). Row clicks dispatchpendingDeeplinkcommands through the canvas chat store, reusing the same navigation path as chat deeplink chips.deeplinkNavigation.ts. Fixes two cross-scope bugs: (1) silent no-op when drilling into a node on a different sub-canvas (now climbs to root, waits for the canvas swap, then drills in), and (2) stalecurrentRefclosure producing a wrong focus zoom (canvas data now resolved at call time via refs after navigation resolves). The navigation is guarded against mid-flight re-entry, never throws, and always clears thependingDeeplinkslot.Test plan
npx vitest run src/__tests__/unit/canvas/liveNowPanel.test.tsx src/__tests__/unit/canvas/nodeDeepLink.test.ts— 23/23 passing