Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Jamie] Fix colSpan and stale unit tests after Score column split #5205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
[Jamie] Fix colSpan and stale unit tests after Score column split #5205
Changes from all commits
a5927ca60ea86e3030e18File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Check failure on line 336 in src/__tests__/unit/components/BenchmarkRunsHistory.test.tsx
src/__tests__/unit/components/BenchmarkRunsHistory.test.tsx > BenchmarkRunsHistory > renders PASS badge and score when all_pass=true and n_passed/n_total present
Check failure on line 351 in src/__tests__/unit/components/BenchmarkRunsHistory.test.tsx
src/__tests__/unit/components/BenchmarkRunsHistory.test.tsx > BenchmarkRunsHistory > renders score with no badge when all_pass=false
Check failure on line 1241 in src/__tests__/unit/components/BenchmarkRunsHistory.test.tsx
src/__tests__/unit/components/BenchmarkRunsHistory.test.tsx > BenchmarkRunsHistory — run types > renders score and report link on recursion rows that carry them
Check failure on line 1369 in src/__tests__/unit/components/BenchmarkRunsHistory.test.tsx
src/__tests__/unit/components/BenchmarkRunsHistory.test.tsx > BenchmarkRunsHistory — graph-first score numerators > scores a recursion row from the graph output joined by projectId suffix
Check failure on line 1396 in src/__tests__/unit/components/BenchmarkRunsHistory.test.tsx
src/__tests__/unit/components/BenchmarkRunsHistory.test.tsx > BenchmarkRunsHistory — graph-first score numerators > falls back to the result-table score when no graph output joins
Check failure on line 1422 in src/__tests__/unit/components/BenchmarkRunsHistory.test.tsx
src/__tests__/unit/components/BenchmarkRunsHistory.test.tsx > BenchmarkRunsHistory — graph-first score numerators > prefers the graph output over echoed counts on a manual row and requests its trigger ref
Check failure on line 1460 in src/__tests__/unit/components/BenchmarkRunsHistory.test.tsx
src/__tests__/unit/components/BenchmarkRunsHistory.test.tsx > BenchmarkRunsHistory — graph-first score numerators > a stored evalOutputRef pointer scores verbatim from the node — both numbers, no roster overlay
Uh oh!
There was an error while loading. Please reload this page.