Generated with Hive: Remove Chat column from Legal Benchmark runs table - #5223
Merged
tomsmith8 merged 5 commits intoSep 2, 2026
Merged
Conversation
UI-only removal: the Chat header, the row's Chat/dash ternary cell, and the ChatCell renderer are deleted from BenchmarkRunsHistory. The underlying Jamie chat data (generateJamieChat/jamieChatStatus/jamieChatPath) is still parsed by useLegalBenchmarkRunList and generation is untouched — only the table column is gone. colSpan value is unchanged (a Fail column follows in the next commit); only its comment is updated.
FailCell threads AdjustedRun.n_failed (already computed by rubricBreakdown) straight into the UI, with the same hasScoreData dash + n/a-unknown + zero-is-a-number conventions as the Contested/Disputed cells. Score column order is now Pass, Fail, Contested, Disputed, Total, with Total moved last so the roster total reads as the closing figure. No scoring logic changes: n_failed is rendered, never recomputed, and PassCell/rubric-scoring.ts are untouched.
- Delete Chat-column-specific tests (header, View Chat link) and replace with a single assertion that the report-chat-link never renders, even when jamieChatPath is present. - Rewrite the 'Pending spinner' test to key off generateRunReport (the ReportCell's own field) instead of generateJamieChat, since ChatCell no longer exists to render that spinner. - Drop the now-impossible 'jamieChatStatus failed -> text-destructive' test (no such element renders anymore). - Fix colSpan test title (10, not 9 + Chat) and header assertions to expect Pass/Fail/Total with no Chat/Score headers. - Add a header-order assertion pinning Pass, Fail, Contested, Disputed, Total. - Add Fail-cell value tests: computed count, output-ref n/a-never-0, muted dash for no-score-data rows, and 0-never-negative on a clamped row. - Add generateRunReport to the makeRun fixture's override type.
…ove-chat-column-legal-benchmark-1788354392
tomsmith8
enabled auto-merge (squash)
September 2, 2026 13:07
…shards The Playwright shard 3/3 CI failure was not a test/timeout issue in the app — actions/upload-artifact@v4's CreateArtifact call timed out 5/5 attempts due to a GitHub Actions infra hiccup, failing the whole shard job even though all Playwright tests had already passed. Mark the blob-report upload step continue-on-error so a flaky artifact-service outage doesn't fail the job; the merge/report job already treats missing blob reports as ignorable (download-artifact continue-on-error + a 'no reports found' fallback).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated with Hive: Remove Chat column from Legal Benchmark runs table