[Jamie] Allow slashes in OTHER/OpenRouter LLM model names - #5231
Merged
Conversation
PR #5227 added `SAFE_NAME_RE` that rejects `/` in `LlmModel.name`. OpenRouter ids are `vendor/model` and are stored in `name` for `provider=OTHER`, so admin save/edit of those rows now 400s. This keeps the slash block for first-class providers (the xAI key-confusion case) and allows `/`-delimited segments only when `provider` is `OTHER`. `providerLabel` still cannot contain slashes (it is the first path segment used for API-key resolution).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #5227 added
SAFE_NAME_REthat rejects/inLlmModel.name. OpenRouter ids arevendor/modeland are stored innameforprovider=OTHER, so admin save/edit of those rows now 400s.This keeps the slash block for first-class providers (the xAI key-confusion case) and allows
/-delimited segments only whenproviderisOTHER.providerLabelstill cannot contain slashes (it is the first path segment used for API-key resolution).