Skip to content

Generated with Hive: Reorder workspace detail tabs and update tab logic on iOS #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomastiminskas wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Generated with Hive: Reorder workspace detail tabs and update tab logic on iOS #532

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions sphinx/Scenes/Dashboard/Workspaces/WorkspaceViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class WorkspaceViewController: PopHandlerViewController {
@IBOutlet weak var containerView: UIView!

private var workspace: Workspace!
private var currentTab: Int = 0 // 0 = Features, 1 = Tasks, 2 = Graph Chat
private var currentTab: Int = 0 // 0 = Tasks, 1 = Features, 2 = Graph Chat, 3 = Pods

private var activeFeaturesVC: WorkspaceFeaturesViewController!
private var activeTasksVC: WorkspaceTasksViewController!
Expand Down Expand Up @@ -97,9 +97,9 @@ class WorkspaceViewController: PopHandlerViewController {
// Only reload data; never touch visibility — the search overlay (if active)
// already covers the tab/content stack, so its isHidden state must not change.
if currentTab == 0 {
activeFeaturesVC?.loadFeatures()
} else if currentTab == 1 {
activeTasksVC?.loadTasks()
} else if currentTab == 1 {
activeFeaturesVC?.loadFeatures()
} else if currentTab == 3 {
activePodsVC?.loadPods()
}
Expand Down Expand Up @@ -196,9 +196,9 @@ class WorkspaceViewController: PopHandlerViewController {

@objc private func createFeatureButtonTapped() {
if currentTab == 0 {
activeFeaturesVC?.createButtonTapped()
} else if currentTab == 1 {
activeTasksVC?.createButtonTapped()
} else if currentTab == 1 {
activeFeaturesVC?.createButtonTapped()
}
}

Expand All @@ -214,7 +214,7 @@ class WorkspaceViewController: PopHandlerViewController {
topTabSegmentedControl.buttonBackgroundColor = .Sphinx.HeaderBG
topTabSegmentedControl.selectorViewColor = .Sphinx.PrimaryGreen
topTabSegmentedControl.configureFromOutlet(
buttonTitles: ["FEATURES", "TASKS", "GRAPH CHAT", "PODS"],
buttonTitles: ["TASKS", "FEATURES", "GRAPH CHAT", "PODS"],
initialIndex: 0,
delegate: self
)
Expand Down Expand Up @@ -369,7 +369,7 @@ extension WorkspaceViewController: CustomSegmentedControlDelegate {

private func switchToTab(_ index: Int) {
currentTab = index
createFeatureButton.isHidden = (index == 2 || index == 3)
createFeatureButton.isHidden = (index == 0 || index == 2 || index == 3)

// Instantiate children lazily, but only make them visible when search is inactive
let searchActive = searchVC != nil
Expand All @@ -380,6 +380,14 @@ extension WorkspaceViewController: CustomSegmentedControlDelegate {
activePodsVC?.view.isHidden = true

if index == 0 {
if activeTasksVC == nil {
activeTasksVC = WorkspaceTasksViewController.instantiate(workspace: workspace)
addChildVC(activeTasksVC)
}
if !searchActive {
activeTasksVC.view.isHidden = false
}
} else if index == 1 {
if activeFeaturesVC == nil {
activeFeaturesVC = WorkspaceFeaturesViewController.instantiate(workspace: workspace)
addChildVC(activeFeaturesVC)
Expand All @@ -388,14 +396,6 @@ extension WorkspaceViewController: CustomSegmentedControlDelegate {
if !searchActive {
activeFeaturesVC.view.isHidden = false
}
} else if index == 1 {
if activeTasksVC == nil {
activeTasksVC = WorkspaceTasksViewController.instantiate(workspace: workspace)
addChildVC(activeTasksVC)
}
if !searchActive {
activeTasksVC.view.isHidden = false
}
} else if index == 2 {
if activeGraphChatVC == nil {
activeGraphChatVC = WorkspaceGraphChatViewController.instantiate(workspace: workspace)
Expand Down