Clear push notifications when one is opened - #741
Open
caydyan wants to merge 1 commit into
Open
Conversation
Author
|
Current-head validation rerun on
I also retried |
Author
|
Follow-up validation on Additional validation:
The extra Gradle flags are local toolchain flags for this checkout's older KAPT setup on JDK 17; no source changes were needed, and the local worktree is clean. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #428
Summary
clearAllNotifications()to the Sphinx notification manager abstraction and Android implementation.MainActivityis launched or re-opened from a push notification intent.chat_idextra after handling it so the notification navigation is not processed again later, and accept string/int/long chat IDs.Validation
git diff --checkJAVA_HOME=/opt/homebrew/opt/openjdk@17/libexec/openjdk.jdk/Contents/Home ANDROID_HOME=/tmp/codex-android-sdk-real ./gradlew :sphinx:application:data:concepts:concept-sphinx-notification-manager:compileKotlin --no-daemonJAVA_HOME=/opt/homebrew/opt/openjdk@17/libexec/openjdk.jdk/Contents/Home ANDROID_HOME=/tmp/codex-android-sdk-real ./gradlew :sphinx:application:data:features:feature-sphinx-notification-manager:compileDebugKotlin --no-daemonJAVA_HOME=/opt/homebrew/opt/openjdk@17/libexec/openjdk.jdk/Contents/Home ANDROID_HOME=/tmp/codex-android-sdk-real ./gradlew :sphinx:activity:main:activitymain:compileDebugKotlin --no-daemon; the local build repeatedly progressed through the modified notification modules and intoactivitymain/dashboard data binding, then failed while resolving remote runtime dependencies because Maven/Google/GitHub raw downloads intermittently terminated TLS handshakes. No source compile error was observed before those dependency-resolution failures.Bounty payout address:
bc1qev5ant33v5y89qqjvcf4mh9hlax5svqf5xd7gc