[codex] Remove persisted bounty summary column

db/config.go

@@ -111,6 +111,7 @@ func InitDB() {
 	db.AutoMigrate(&BountyStakeProcess{})
 
 	DB.MigrateTablesWithOrgUuid()
+	DB.DropLegacyBountySummaryColumn()
 	DB.MigrateOrganizationToWorkspace()
 
 	people := DB.GetAllPeople()
@@ -272,6 +273,12 @@ func (db database) MigrateTablesWithOrgUuid() {
 	}
 }
 
+func (db database) DropLegacyBountySummaryColumn() {
+	if db.db.Migrator().HasTable(&Bounty{}) && db.db.Migrator().HasColumn(&Bounty{}, "one_sentence_summary") {
+		db.db.Migrator().DropColumn(&Bounty{}, "one_sentence_summary")
+	}
+}
+
 func (db database) MigrateOrganizationToWorkspace() {
 	if (db.db.Migrator().HasTable(&Organization{}) && !db.db.Migrator().HasTable("workspaces")) {
 		db.db.Migrator().RenameTable(&Organization{}, "workspaces")

db/structs.go

@@ -399,7 +399,7 @@ type Bounty struct {
 	WantedType              string                 `json:"wanted_type"`
 	Deliverables            string                 `json:"deliverables"`
 	GithubDescription       bool                   `json:"github_description"`
-	OneSentenceSummary      string                 `json:"one_sentence_summary"`
+	OneSentenceSummary      string                 `gorm:"-" json:"one_sentence_summary"`
 	EstimatedSessionLength  string                 `json:"estimated_session_length"`
 	EstimatedCompletionDate string                 `json:"estimated_completion_date"`
 	Created                 int64                  `json:"created"`
@@ -446,7 +446,7 @@ type NewBounty struct {
 	WantedType              string                 `json:"wanted_type"`
 	Deliverables            string                 `json:"deliverables"`
 	GithubDescription       bool                   `json:"github_description"`
-	OneSentenceSummary      string                 `json:"one_sentence_summary"`
+	OneSentenceSummary      string                 `gorm:"-" json:"one_sentence_summary"`
 	EstimatedSessionLength  string                 `json:"estimated_session_length"`
 	EstimatedCompletionDate string                 `json:"estimated_completion_date"`
 	Created                 int64                  `json:"created"`

db/structs_test.go

@@ -0,0 +1,34 @@
+package db
+
+import (
+	"sync"
+	"testing"
+
+	"gorm.io/gorm/schema"
+)
+
+func TestBountySummaryIsNotPersisted(t *testing.T) {
+	models := []struct {
+		name  string
+		value interface{}
+	}{
+		{name: "Bounty", value: &Bounty{}},
+		{name: "NewBounty", value: &NewBounty{}},
+	}
+
+	for _, model := range models {
+		t.Run(model.name, func(t *testing.T) {
+			parsed, err := schema.Parse(model.value, &sync.Map{}, schema.NamingStrategy{})
+			if err != nil {
+				t.Fatalf("parse schema: %v", err)
+			}
+
+			if field := parsed.LookUpField("OneSentenceSummary"); field == nil || field.DBName != "" {
+				t.Fatalf("OneSentenceSummary should not be mapped to a database column, got %#v", field)
+			}
+			if field := parsed.LookUpField("one_sentence_summary"); field != nil {
+				t.Fatalf("one_sentence_summary should not be mapped to database field %q", field.Name)
+			}
+		})
+	}
+}

db/test_config.go

@@ -95,6 +95,8 @@ func InitTestDB() {
 	db.AutoMigrate(&ChatWorkflowStatus{})
 	db.AutoMigrate(&BountyStakeProcess{})
 
+	TestDB.DropLegacyBountySummaryColumn()
+
 	people := TestDB.GetAllPeople()
 	for _, p := range people {
 		if p.Uuid == "" {

handlers/bounties.go

@@ -191,13 +191,6 @@ func MigrateBounties(w http.ResponseWriter, r *http.Request) {
 				migrateBountyFinal.GithubDescription = GithuDescription
 			}
 
-			OneSentenceSummary, ok15 := migrateBounty["one_sentence_summary"].(string)
-			if !ok15 {
-				migrateBountyFinal.OneSentenceSummary = ""
-			} else {
-				migrateBountyFinal.OneSentenceSummary = OneSentenceSummary
-			}
-
 			EstimatedSessionLength, ok16 := migrateBounty["estimated_session_length"].(string)
 			if !ok16 {
 				migrateBountyFinal.EstimatedSessionLength = ""

handlers/bounty.go

@@ -829,7 +829,7 @@ func (h *bountyHandler) GenerateBountyResponse(bounties []db.NewBounty) []db.Bou
 				WantedType:              bounty.WantedType,
 				Deliverables:            bounty.Deliverables,
 				GithubDescription:       bounty.GithubDescription,
-				OneSentenceSummary:      bounty.OneSentenceSummary,
+				OneSentenceSummary:      bounty.Title,
 				EstimatedSessionLength:  bounty.EstimatedSessionLength,
 				EstimatedCompletionDate: bounty.EstimatedCompletionDate,
 				OrgUuid:                 bounty.WorkspaceUuid,

handlers/features_test.go

@@ -2800,7 +2800,7 @@ func TestGetBountiesByFeatureAndPhaseUuid(t *testing.T) {
 				WantedType:              "",
 				Deliverables:            "",
 				GithubDescription:       false,
-				OneSentenceSummary:      "",
+				OneSentenceSummary:      "test-bounty",
 				EstimatedSessionLength:  "",
 				EstimatedCompletionDate: "",
 				Created:                 0,