Fix throttle not clearing its internal interval when unsubscribed#337
Open
Avaq wants to merge 1 commit intostaltz:masterfrom
Open
Fix throttle not clearing its internal interval when unsubscribed#337Avaq wants to merge 1 commit intostaltz:masterfrom
Avaq wants to merge 1 commit intostaltz:masterfrom
Conversation
When a throttled stream is unsubscribed, its internal throttle interval is not cleared, and the reference to its ID is removed, meaning it's also not cleared at the end of the timeout. This is essentially a memory leak, where the interval will live on in the event loop forever without being cleared. This commit adds a call to ThrottleOperator#clearInterval() in its _stop method, clearing the interval and freeing it from the event loop.
4126438 to
f2631ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a throttled stream is unsubscribed, its internal throttle interval is not cleared, and the reference to its ID is removed, meaning it's also not cleared at the end of the timeout.
This is essentially a memory leak, where the interval will live on in the event loop forever without being cleared.
This PR adds a call to
ThrottleOperator#clearInterval()in its_stopmethod, clearing the interval and freeing it from the event loop.I checked if the same problem exists for
debounce, but it looks like it was already fixed in #296:xstream/src/extra/debounce.ts
Lines 18 to 22 in fee5f0d