Conversation
Contributor
|
Well spotted. We missed these test files when updated the posteriord with the new syntax. Let the tests pass and we can merge. |
Member
Author
|
@MansMeg can you tag a release, so that r-universe will update and pass the checks, too |
Contributor
|
Yes! Will do asap. |
Contributor
|
Now fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
inst/test_files/eight_schools_noncentered.stan was using the old Stan syntax, which did work in github actions using CRAN release of rstan, but failed in r-universe.dev as r-universe has a more recent rstan version. As the current CRAN release works with both syntaxes, after this the tests should pass both in github and in r-universe
(thanks for @jgabry and @WardBrian helping to figure this out)