Adds a folder for Turing models, and a few models for testing, #262
Open
JasonPekos wants to merge 4 commits intostan-dev:developmentfrom
Open
Adds a folder for Turing models, and a few models for testing, #262JasonPekos wants to merge 4 commits intostan-dev:developmentfrom
JasonPekos wants to merge 4 commits intostan-dev:developmentfrom
Conversation
New stan syntax and tags
Author
|
Converting this to a draft — just noticed that I need to change the corresponding info files as well, to add a turing model section, e.g.: (for the folder:) "model_implementations": {
"stan": {
"model_code": "models/stan/eight_schools_noncentered.stan",
"stan_version": ">=2.26.0"
},
"pymc3": {
"model_code": "models/pymc3/eight_schools_noncentered.py"
},
"turing": {
"model_code": "models/turing/eight_schools_noncentered"
}
},(for the actual code file:) "model_implementations": {
"stan": {
"model_code": "models/stan/eight_schools_noncentered.stan",
"stan_version": ">=2.26.0"
},
"pymc3": {
"model_code": "models/pymc3/eight_schools_noncentered.py"
},
"turing": {
"model_code": "models/turing/eight_schools_noncentered/eight_schools_noncentered.jl"
}
},not sure what is ideal here. |
Author
|
Ok, updated the |
Collaborator
|
This looks good to me. I have two thoughts.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds a few Turing models:
eight_schools_noncenteredandeight_schools_centered. (chosen because they're classic)earn_height(chosen because the data needed for this model is a subset of the dataframe, re: Proposal: Adddata-usedto posterior.jsonfiles where relevant #260))ness(chosen because the model has multiple associated posteriors, for different data)Rationale
Eventually the rest of the Turing models are probably going to live here. For now, while I'm building out the Julia testing and benchmarking code, I'd like some models in the actual repository to test my code on.
These models cover some edge cases that I want to make sure my code covers.