Repository navigation
Conversation
T1 display power is HID feature report 3 on the iBridge HID interface, byte 1 = 0x01 parked or 0x02 awake. The driver only ever wrote 0x01, on suspend, and the firmware keeps the value across a reprobe, so a parked panel stayed dark through every later probe while accepting every frame: DRM registered, renderer frames held, no error anywhere. Share the report write between park and a new wake, and write the awake value after the probe-time clear and at the end of the resume rearm. A failed awake write is a warning, not a probe or rearm failure. Attended control on a MacBookPro14,2 running 0.1.12, hardware service stopped: park from userspace, unload and load the unmodified driver, panel stays dark; unload and load this driver, panel relights from probe alone with no "Failed to wake" warning. Suspend/resume was not exercised on that unit, so the standardagents#18 path (stock rearm never wrote the awake value either) remains to be observed. The resume fault test gains the WAKE step and checks that its failure is reported without failing the rearm. docs/display-failures.md records the control and what remains unobserved.
|
Tested the idea behind this on the #18 path, on a MacBookPro14,3 with s2idle (deep S3 doesn't come back on this machine at all). I didn't build this branch; I did the same write from userspace. Setup: Omarchy 4.0.4-1, kernel 7.2.5-3-omarchy, official t1bridge 0.1.12 packages, diagnostics on. After one s2idle cycle (
Then I read feature report 3 on interface 6 (hidraw, page 0xff12) with So it was parked, and it had stayed parked through all of the above. Writing the 15-byte report from this PR ( I've since put the same write in a system-sleep So on 14,3 + s2idle the awake write at rearm looks like exactly what #18 is missing. I can run a build of this branch through a few suspend cycles here if that helps. |
|
This answers the open question in the description: on a unit that sleeps, writing the awake value at the end of the rearm does fix the #18 path. I found the same root cause independently and opened #49 the next day without having seen this PR. The code change is the same: report 3, byte 1 = Machine. MacBookPro14,3 (Radeon Pro 555 on the panel), T1Bridge 0.1.12 DKMS rebuilt with the awake write at the end of
Not covered. This is s2idle only. For S3 on a 14,3, the comment from @darrellgum on #18 found that the awake write alone isn't enough: One difference from #49. There, a failed awake write at resume takes the reprobe path from #27. Here it warns and continues. Either is fine for the case I tested, because the write never failed. Warn-and-continue leaves the bar dark if the write does fail, and a reprobe would retry it. Since this PR came first and also covers probe, I'm happy to close #49 in its favor, or to move its fault-test step here if that's useful. @andrew-boyd, your call. |
|
Adding an actual build-and-hardware report from MacBookPro13,3 (2016 15-inch T1). I tested this PR at Observed results: seven attended sleep/resume cycles restored visible Touch Bar icons and Fn switching without a manual unpark. Four were on These were confirmed The separate ACPICA correction carried by omacom/omarchy-pkgs#544 reduced visible wake from 17–18 seconds to about one second / nearly immediate in the first two attended patched-kernel tests. That timing improvement is separate from this display fix. This favors using the driver fix instead of shipping my additional userspace recovery hook. It does not validate S3, multi-hour display recovery, external ports or Touch ID. Severe closed-lid battery depletion also remains unresolved. Test chronology and limitations. |
|
MacBookPro14,2, stock t1bridge 0.1.12-1, Omarchy 4.5.0-3, kernel After two deep suspends the strip was dark and report 3 byte 1 was Details are on #18. No SOCW call. |
|
Follow-up to the 14,2 note above. With report 3 already |
Refs #34, #18.
T1 display power is HID feature report 3 on the iBridge HID interface, byte 1 =
0x01parked /0x02awake. The driver only ever wrote0x01(on suspend) and the firmware keeps the value across a reprobe, so a parked panel stays dark through every later probe while accepting every frame: DRM registered, renderer frames held, no error anywhere.This shares the report write between park and a new wake, and writes the awake value after the probe-time clear and at the end of the resume rearm. A failed awake write warns and continues; it never fails probe or rearm.
Tested. Attended control on a MacBookPro14,2 (Arch/Omarchy, kernel 7.2.5, t1bridge 0.1.12), lid open,
t1-touchbar-hwstopped:0x01) → darkrmmod+insmodthe unmodified v0.1.12 driver → stays darkrmmod+insmodthis driver → relights from probe alone, no "Failed to wake" warning in dmesgmake -C kernel/appletbdrm-t1 test sanitizepasses with the new WAKE step. Suspend/resume was not exercised on that unit (sleep masked), so whether this also repairs the #18 path, where the stock rearm never wrote the awake value either, is left as "to be observed" indocs/display-failures.md.Not touched:
kernel/appletbdrm-t1/upstream/*.patch(the mainline series); happy to refresh it if you want this carried there.🤖 Generated with Claude Code