Skip to content

dkms.conf: bump PACKAGE_VERSION to 0.1.12 - #67

Open
frozenSolid wants to merge 1 commit into
standardagents:mainfrom
frozenSolid:dkms-conf-version
Open

frozenSolid wants to merge 1 commit into
standardagents:mainfrom
frozenSolid:dkms-conf-version

Conversation

@frozenSolid

Copy link
Copy Markdown

kernel/dkms/dkms.conf still says PACKAGE_VERSION="0.1.11", while
packaging/arch/t1bridge-dkms/PKGBUILD is pkgver=0.1.12 and installs that same file into
/usr/src/t1bridge-dkms-0.1.12/. So the version DKMS records doesn't match the source
directory or the package.

Arch packages evidently still install, so this is a consistency fix, not a reported breakage.
It does matter for anything that derives the DKMS source directory from dkms.conf. A Fedora
source install that did so created /usr/src/t1bridge-dkms-0.1.11 for 0.1.12 sources.

If the version is meant to be bumped by the release process, a check in tools/release that
dkms.conf matches pkgver would prevent a repeat. I didn't add one; happy to if wanted.

Testing

  • git diff: one line.
  • dkms add/build/install with this dkms.conf from /usr/src/t1bridge-dkms-0.1.12 on
    Fedora 45 / kernel 7.2.15: not run with the bumped file. Build of all four modules from the
    same sources passes (make -C kernel/dkms).

🤖 Generated with Claude Code

kernel/dkms/dkms.conf still reported 0.1.11 while the packages are
0.1.12 and install it into /usr/src/t1bridge-dkms-0.1.12.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@standard-agents-pr-reviewer standard-agents-pr-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the full before/after DKMS configuration and its Arch packaging consumer. The sole change sets PACKAGE_VERSION to 0.1.12, matching pkgver and the /usr/src/t1bridge-dkms-0.1.12 destination used by the PKGBUILD. Module names, build commands, installation locations, and autoinstall behavior are unchanged. No actionable regression found. Static source review only; no build or DKMS installation tests were run.

Static adversarial review of fa40ad3 against 81cbdf8. Code was read, not executed.

@baowerk

baowerk commented Nov 18, 2026

Copy link
Copy Markdown

Confirming this on a MacBook Pro 14,3 (T1), Arch-based distro, kernel 7.2.15.

The signed 0.1.12 package installs this file as /usr/src/t1bridge-dkms-0.1.12/dkms.conf,
but it still says PACKAGE_VERSION="0.1.11". Every earlier release bumped this line
together with pkgver, so it looks like it was just missed for 0.1.12.

With exactly this one-line change, make -C packaging/arch/t1bridge verify passes.
DKMS takes the version from the source folder, so this line doesn't affect the module
build. LGTM.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants