Repository navigation
dkms.conf: bump PACKAGE_VERSION to 0.1.12 - #67
frozenSolid wants to merge 1 commit into
Conversation
kernel/dkms/dkms.conf still reported 0.1.11 while the packages are 0.1.12 and install it into /usr/src/t1bridge-dkms-0.1.12. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Reviewed the full before/after DKMS configuration and its Arch packaging consumer. The sole change sets PACKAGE_VERSION to 0.1.12, matching pkgver and the /usr/src/t1bridge-dkms-0.1.12 destination used by the PKGBUILD. Module names, build commands, installation locations, and autoinstall behavior are unchanged. No actionable regression found. Static source review only; no build or DKMS installation tests were run.
Static adversarial review of fa40ad3 against 81cbdf8. Code was read, not executed.
|
Confirming this on a MacBook Pro 14,3 (T1), Arch-based distro, kernel 7.2.15. The signed 0.1.12 package installs this file as With exactly this one-line change, |
kernel/dkms/dkms.confstill saysPACKAGE_VERSION="0.1.11", whilepackaging/arch/t1bridge-dkms/PKGBUILDispkgver=0.1.12and installs that same file into/usr/src/t1bridge-dkms-0.1.12/. So the version DKMS records doesn't match the sourcedirectory or the package.
Arch packages evidently still install, so this is a consistency fix, not a reported breakage.
It does matter for anything that derives the DKMS source directory from
dkms.conf. A Fedorasource install that did so created
/usr/src/t1bridge-dkms-0.1.11for 0.1.12 sources.If the version is meant to be bumped by the release process, a check in
tools/releasethatdkms.confmatchespkgverwould prevent a repeat. I didn't add one; happy to if wanted.Testing
git diff: one line.dkms add/build/installwith thisdkms.conffrom/usr/src/t1bridge-dkms-0.1.12onFedora 45 / kernel 7.2.15: not run with the bumped file. Build of all four modules from the
same sources passes (
make -C kernel/dkms).🤖 Generated with Claude Code