This repository was archived by the owner on Nov 5, 2019. It is now read-only.
Add 3D Touch functionality to StandardNotes#46
Open
flowinho wants to merge 13 commits intostandardnotes:masterfrom
flowinho:master
Open
Add 3D Touch functionality to StandardNotes#46flowinho wants to merge 13 commits intostandardnotes:masterfrom flowinho:master
flowinho wants to merge 13 commits intostandardnotes:masterfrom
flowinho:master
Conversation
The ViewControllers are not usable on their own and need to be displayed by an embedded navigation controller. When instantiating a view controller without pushing it through a navigation controller, the topBar is missing, leaving the user without a [Done] button. A first step solution that doesnt require structural changes to the storyboard would be to gain access to the current displaying viewController and make it push the composer viewcontroller. However, an optional binding check for NotesViewController on the selectedViewController-Property of the apps tabbarcontroller fails.
This reverts commit 07d76c3.
Author
|
So this has been lying around since ages now and conflicts start to arise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3D Touch for SN for iOS
Good day,
as previously discussed in the Slack channel, i've created an implemention of 3D Touch application shortcuts so users can quickly navigate to either the Notes List or the Note composer.
Known issues
As discussed in the Slack channel, the app features a navigational / structural implementation of stacked viewcontrollers that is quite hard to utilize in a "apple-y" way, at least for me.
This version of 3d touch works but has some querks when 3D Touch is enable.
This is due to a navigation call that is made inside the 3d touch authentication function.
Assets
All assets are system-provided by iOS, no license agreements breached 🗡