Feature/digital world clock - #165
Conversation
…e aplicaciones al espanol
…active zone count
starbrightlab
left a comment
There was a problem hiding this comment.
Nice addition — reviewed the two world-clock commits (independent of the i18n base). Correctness is solid: DST-safe (TimeZone.getTimeZone(zone)), respects use24HourClock (AUTO/12/24), and the LaunchedEffect tick actually updates. Integration follows the existing analog-widget pattern at all the right points, DisposableEffect cleans up the observer, no new persisted setting → tripwires stay green. This is close to mergeable.
A few nits before merge:
- Don't repurpose the Timers glyph.
ca7cab9changed the shipped Timers icon⏱ → ⌛purely to free⏱for the new clock (HomeActivity.kt:3198). That silently alters an existing widget (and an hourglass suits a timer worse). Please give the digital clock its own glyph and leave Timers as-is. - Tick per-minute, not per-second. The digital face shows only
HH:mmyet wakes every second (delay(1000)), andremember(zone, now, ...)re-keys onnowso it memoizes nothing. On an always-on OLED launcher, per-minute is easier on power/burn-in. - Optional: the digital and analog widgets share ~all their scaffolding (state, lifecycle observer, tick, responsive layout) — a shared helper would avoid future double-maintenance. And at 3–4 zones the time
TextismaxLines=1with nooverflow = Ellipsis, so a wide "12:45 PM" can clip.
Fix 1 and 2 and I'm happy to merge.
… handle overflow in Digital World Clock
|
Reviewed the Digital World Clock and I like it. The minute-boundary tick is genuinely nicer than the analog widget's 1-second poll, the responsive sizing for 1-4 zones is well thought out, and making the analog clock responsive along the way is a welcome touch. I want this in. Two things block merging as filed:
If the rebase is a pain, happy to cherry-pick the three widget commits myself with authorship preserved, same as #168. Thanks again, this and the transitions PR are shaping up to be a great run of contributions. |
This PR introduces a new built-in Digital World Clock widget alongside the existing analog world clock:
ImmortalSettings.use24HourClock(12-hour vs 24-hour format).I18n.kt.