fix: point Tyler Gibbs testimonial at his current avatar - #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The Tyler Gibbs testimonial on the landing page renders a broken-image icon instead of an avatar.
TestimonialCardhotlinks the author'spbs.twimg.comprofile image. Twitter mints a new profile-image path whenever a user changes their picture and lets the old path 404 — Tyler changed his, so the stored URLnow returns 404 in every size variant (
_normal,_bigger,_200x200, bare). The card renders<img>with no error fallback, so the dead URL shows as the browser's broken-image glyph next to the name and handle.Fix
Point the entry at his current avatar (
2077596476687998978/WvlUT0v1). Verified 200 both as stored (_normal) and as rendered —TestimonialCardrewrites_normal→_bigger.Checks
testimonials-data.tsonmainin its rendered form; Tyler's is the only dead one.bun run typecheckandbun run lintclean (lint's 3noImgElementwarnings inattachment-upload.tsxare pre-existing and untouched).Not done
No
onErrorfallback inTestimonialCard— it would make the card a client component for a failure mode that has hit once. Worth adding if a second avatar rots. Migrating avatars tounavatar.iowas considered and dropped: it 403'd on one handle during testing and adds ~1s per image.