Skip to content

Simplify runtime code and fix configuration reload recovery - #2

Merged
tombell merged 6 commits into
mainfrom
codex/review-cleanup
Sep 22, 2026
Merged

tombell merged 6 commits into
mainfrom
codex/review-cleanup

Conversation

@tombell

@tombell tombell commented Sep 22, 2026

Copy link
Copy Markdown
Member

Restoring the exact last valid configuration after an invalid edit left the reload error reported. Move the change check into the configuration store so restoration clears the error and runtime overrides, while unchanged files preserve overrides.

Simplify queued runtime updates, remove unused border state, shorten internal and test names, and apply declaration ordering and statement spacing. Remove a duplicate socket round-trip test, three JSONC syntax cases covered by the shared package, and a redundant immutability assertion. Condense the internal documentation and distinguish current behavior from remaining validation work.

Validation:

  • Strict formatting and whitespace checks passed.
  • All 37 Swift tests passed, including regression coverage for watched reload recovery.
  • CLI version and example configuration validation passed.
  • A temporary live daemon with borders disabled passed startup, queries, unchanged-file override preservation, invalid-edit recovery, restoration of identical valid contents, and stop/socket cleanup checks.

Desktop rendering transitions were not rerun.

@tombell
tombell force-pushed the codex/review-cleanup branch from a9e683b to dd0a47e Compare September 22, 2026 07:59
@tombell
tombell merged commit 153bb88 into main Sep 22, 2026
1 check passed
@tombell
tombell deleted the codex/review-cleanup branch September 22, 2026 18:30
@tombell tombell added type: bug Broken behavior and regressions area: runtime Daemon lifecycle, event batching, reconciliation, and update scheduling area: configuration Config parsing, validation, schema, defaults, reload, and runtime overrides labels Oct 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: configuration Config parsing, validation, schema, defaults, reload, and runtime overrides area: runtime Daemon lifecycle, event batching, reconciliation, and update scheduling type: bug Broken behavior and regressions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant