fix: phpldapadmin LDAP connection and login configuration#8
Merged
Conversation
- Pass LDAP_BASE_DN, LDAP_USERNAME, LDAP_PASSWORD from openldap config - Set LDAP_LOGIN_ATTR=DN and LDAP_ALERT_ROOTDN=false by default - Add extraEnv support for phpldapadmin - Add ldap.loginAttr and ldap.alertRootDN to values - Bump chart to 1.4.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LDAP_LOGIN_ATTR=DNby default so admin can login with full DNLDAP_ALERT_ROOTDN=falseto allow rootdn loginextraEnvsupport for custom env varsldap.loginAttrandldap.alertRootDNto values for configurabilityWhy
The new phpLDAPadmin (leenooks) reads config from env vars but the chart was not passing the LDAP connection details, causing login failures after migration from osixia.
Test plan
helm templaterenders all expected env vars