Repository navigation
Fix newsletter test personalization and record Staging QA - #217
Merged
Merged
Conversation
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test emails left
{{{contact.first_name}}}literal because sample substitution only supported the default fallback form. The test-send renderer now resolves first-name placeholders with or without a fallback and preserves other contact fields. An independent regression test covers both forms, Unicode and literal replacement characters.The release review now records the completed Cockpit-Staging checks: Blob upload, contact and segment sync, sandbox group import, isolated real CSV import, direct test delivery, scheduled-send cancellation, a real QA broadcast, inbox authentication, preference links and analytics. The report also records the separate Next.js security fix and removal of newsletter writing assistance.
Validation: 479 tests pass, TypeScript passes, changed files pass Biome, and the local production build passes. After this PR reaches Staging, the corrected plain first-name tag will receive a final real test-send check. Production is prepared through release PR #215 and will not be deployed by this PR.