Skip to content

Fix newsletter test personalization and record Staging QA - #217

Merged
jannikbln merged 1 commit into
mainfrom
codex/newsletter-release-ready
Oct 10, 2026
Merged

jannikbln merged 1 commit into
mainfrom
codex/newsletter-release-ready

Conversation

@jannikbln

Copy link
Copy Markdown
Contributor

Test emails left {{{contact.first_name}}} literal because sample substitution only supported the default fallback form. The test-send renderer now resolves first-name placeholders with or without a fallback and preserves other contact fields. An independent regression test covers both forms, Unicode and literal replacement characters.

The release review now records the completed Cockpit-Staging checks: Blob upload, contact and segment sync, sandbox group import, isolated real CSV import, direct test delivery, scheduled-send cancellation, a real QA broadcast, inbox authentication, preference links and analytics. The report also records the separate Next.js security fix and removal of newsletter writing assistance.

Validation: 479 tests pass, TypeScript passes, changed files pass Biome, and the local production build passes. After this PR reaches Staging, the corrected plain first-name tag will receive a final real test-send check. Production is prepared through release PR #215 and will not be deployed by this PR.

@coderabbitai

coderabbitai Bot commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Repository: startberlin/cockpit/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e7325b03-84de-4431-909f-72f1de09fd38

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jannikbln
jannikbln merged commit f1cf9f6 into main Oct 10, 2026
4 checks passed
@jannikbln
jannikbln deleted the codex/newsletter-release-ready branch October 10, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant