This repository was archived by the owner on Aug 20, 2026. It is now read-only.
Don't gate release/tag pipelines on the ambient CVE backlog - #19
Merged
Conversation
A GitLab tag pipeline's CI_PIPELINE_SOURCE is "push", same as a default-branch push — so scope detection was falling through to "default_branch" and gating unscoped on every tag. Caught live: v1.1.0 on startmatter/up failed cerberus over 4 pre-existing critical dependency CVEs unrelated to that release, even though deploy and create-release both succeeded fine. The tagged commit already scanned and gated on its merge request. Re-running an unscoped sweep on every release just makes shipping hostage to the entire dependency tree's current CVE state rather than what that release actually changed. New "tag" scope still runs the scan for visibility, just never fails the pipeline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Caught live on the first real release after #18: a GitLab tag pipeline's
CI_PIPELINE_SOURCEis"push", same as a default-branch push, so scope detection fell through todefault_branchand gated unscoped —startmatter/up's v1.1.0 release failed cerberus over 4 pre-existing critical dependency CVEs, unrelated to that release (deploy and create-release both succeeded fine).Adds a
tagscope (GitLab:CI_COMMIT_TAGset; GitHub:GITHUB_REFstarts withrefs/tags/) that still runs the scan for visibility but never gates — the tagged commit already earned its gate on the merge request.Test plan
npm run typecheck,npm test(36/36),npm run build