[peristence] Disallow multple namespace configuration entities with same namespace #1808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
anshul98ks123
force-pushed
the
TE-fix-namespace-entity-constraints
branch
from
2dcfa6c to
e0a815a
Compare
anshul98ks123
force-pushed
the
TE-fix-namespace-entity-constraints
branch
from
e0a815a to
b622908
Compare
anshul98ks123
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s)
Currently, the unique namespace constraint doesn't work as expected for NULL namespace
because MySQL doesn’t support direct UNIQUE constraint over nullable columns to also reject multiple NULLs
This can result into situations where multiple rows can exist for NULL namespace
which can break multiple parts of the system
Description
This PR fixes the issue by making the namespace column non null, adding uniqueness constraint over it and also updates the existing NULL namespace rows with NULL value namespace