Conversation
- 버그 수정: keyword 필터링 조건 누락, ExceptionCodeMapper 버그, ExceptionType 수정 - 코드 개선: for문 → stream, split 로직 개선, 에러 처리 강화 - Repository: @Param 패키지 수정, 쿼리 개선 (정렬, distinct, innerJoin) - Controller: null 체크 강화, @apiresponse 정확성 개선 - 기타: 불필요한 import 제거, @OverRide 추가, 정렬 추가
- Controller: 메서드명 수정, 변수명 개선, null 체크 강화, 페이지 검증 추가 - Service: @transactional 추가, @transactional(readOnly = true) 추가 - Repository: limit/offset 계산 검증 추가 (음수 방지)
- Service: null 체크 강화, 조건 로직 개선, switch default 추가, 예외 처리 강화 - Repository: join을 innerJoin으로 명시, limit/offset 검증 추가, @Param 패키지 수정 - Controller: null 체크 강화, 예외 처리 개선 - 매직 넘버 상수화 (TAX_RATE) - 불필요한 import 제거
- Exception 클래스: 코드 포맷팅 개선 (공백 제거) - ExceptionCodeMapper: 오타 수정 (NOT_FOUNE → NOT_FOUND) - GlobalExceptionHandler: 상수 분리, ObjectMapper 재사용, 변수명 개선, 타입 안전성 개선
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🌱 관련 이슈
📌 작업 내용 및 특이사항
📝 참고사항
📚 기타