Repository navigation
Conversation
stasmarkin
pushed a commit
that referenced
this pull request
Jun 17, 2026
stasmarkin
added a commit
that referenced
this pull request
Jun 17, 2026
…nd; tests The #62 fix special-cased neutral ('*') keys with a second handedness lookup inside smtd_chordal_all_same_hand. Fold it into smtd_chordal_same_hand instead, so the neutral-key semantics live in one place and stay in sync with the timeout-cancelling path in SMTD_STAGE_TOUCH (which already uses same_hand). Add regression coverage for the bug #62 fixed: a definite-hand mod-tap plus a following neutral key must HOLD, not roll to a tap. Both the quick-release path (smtd_chordal_all_same_hand) and the timeout path are now asserted, in the Python unit suite and the QMK-native integration suite.
stasmarkin
added a commit
that referenced
this pull request
Jun 17, 2026
Owner
|
Thanks @gitbyflux! Merged your fix into I added a small follow-up on top: instead of a second handedness lookup, the neutral-key case is now folded into Release: https://github.com/stasmarkin/sm_td/releases/tag/v0.6.4 |
stasmarkin
added a commit
that referenced
this pull request
Jun 17, 2026
stasmarkin
added a commit
that referenced
this pull request
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.