[6.x] Fix error caused by empty globals#14098
Merged
jasonvarga merged 2 commits into6.xfrom Feb 27, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where the v5 to v6 update script doesn't account for globals with empty data.
In v5, it was possible to have empty data in globals:
Once the updater had run, the result would be:
Which then throws an error:
This was happening because
Arr::get($contents, 'data', [])returns null when the data key exists but has a null value (the default[]is only used when the key doesn't exist). TheYAML::dump(null)call then produces the literal string null.This PR fixes it by:
Arr::get($contents, 'data') ?? []to properly handle null valuesnullhandling inGlobalVariablesStoreso it gracefully handles YAML files containing nullFixes #14095