Skip to content

Add optional centering of covariates#24

Merged
svteichman merged 13 commits into
statdivlab:mainfrom
svteichman:center
Sep 5, 2025
Merged

Add optional centering of covariates#24
svteichman merged 13 commits into
statdivlab:mainfrom
svteichman:center

Conversation

@svteichman

Copy link
Copy Markdown
Collaborator
  • add optional centering of covariates (does not affect the offset term)
  • this is built within a control list, which we can later build on with user options
  • by default, control$center = FALSE
  • runs tests that show that centering does not affect results in most settings and in some settings is less stable compared to not centering
  • adds NEWS.md file to describe recent changes to package

@codecov

codecov Bot commented Aug 29, 2025

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@adw96 adw96 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great. I made a minor change to clarify why one might use center... but really this looks good.

Did we increment the major release earlier and just not add a NEWS then?

Confirming we are not incrementing the version number now?

I'm happy for you to merge when ready

@svteichman

svteichman commented Sep 5, 2025

Copy link
Copy Markdown
Collaborator Author

Yes, I added a NEWS that really refers to the previous release, and did not increment the version here (it was originally because I was thinking centering would be TRUE by default which would be another breaking change so instead of having two major releases back to back just combine them. But now it's only a minor update).

I updated this now to instead update this version as a minor release and separate out these two pieces in the NEWS.md.

@svteichman svteichman merged commit 0dd26a1 into statdivlab:main Sep 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants