feat(003): product-family registry owns the shared repo list#4
Merged
Conversation
app/lib/product-family.ts had no explicit owner. It fell under spec 001's app/ directory while its content was authored in spec 002, so every family-list edit tripped the coupling gate and needed a Spec-Drift-Waiver (PR #2, PR #3). Spec 003 adopts the module (origin.retroactive: true) and carries the roster, so a repo add or remove is an ordinary co-edit here plus the module, coupling clean with no waiver. No code change ships; the module already matches the roster.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app/lib/product-family.ts(the canonical product-family roster consumed bythe index page, the footer, and the
/registryviewer'srepoMetalookup)had no explicit spec owner: it fell under spec 001's
app/directory while itscontent was authored in spec 002 section 2. Every roster edit therefore tripped
the coupling gate and was cleared with a
Spec-Drift-Waiver:(PR #2 added sixrepos, PR #3 fixed the derived count).
Spec 003 gives the module a single explicit owner and carries the roster in its
section 3, so adding, removing, or re-describing a repo is an ordinary authoring
edit to spec 003 plus the module: it couples clean with no waiver and no edit to
the scaffold (001) or launch-content (002) specs. Marked
origin.retroactive: truebecause the module already exists (it shipped in PR #2); this spec adoptsit rather than claiming creation. No code change ships; the module already
matches the roster.
Testing
spec-spine compile(4 specs, 0 warnings),index,lint --fail-on-warn(0/0/0),
index check(fresh).spec-spine couple --base origin/main --head HEAD:OK, no drift(this PR isspec-only, so no waiver is needed).
product-family.tschanged and spec 003 in the range,couplereportsOK: 2 path(s) checked, no drift, confirming a real roster co-edit no longerneeds a waiver. The module's owner set is now
(001-site-scaffold, 003-product-family-registry).